[15.0][MIG] database_cleanup #2219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoid ''NoneType' object has no attribute 'exists'' error when purging models fix my change [email protected], wrong lines replaced...
raw SQL query (but never read afterwards). Workaround for
lp:1277899
[FIX] Preserve dangling workflow table which is in use
[RFR] Group models per table when detecting columns to purge
to prevent problems with models sharing the same table
[ADD] Allow purging of dangling data entries
[FIX] Data purging now working
[IMP] Docstrings
[FIX] Label
[FIX] Catch attempt to unlink field from nonexisting model
[RFR] Flake8
[CHG] database_cleanup: move description to README.rst
[IMP] order wizard lines by name [IMP] deal with modules whose models can't be loaded [IMP] double quotes for docstring [FIX] use exists query instead of huge in list [IMP] hide unnecessary buttons in wizard II [IMP] readability [FIX] cope with purging nonexisting models
[IMP] adaptto upstream changes
[ADD] test purging modules [ADD] test purging tables
[FIX] database_cleanup reloads the registry which has weird side effects during testing. Take care database_cleanup's tests don't mess up the following tests
* [FIX] database_cleanup: Isolate build * Isolate `database_cleanup` into its own build in Travis file to fix OCA#689 * [FIX] database_cleanup: Remove KeyError assertion * Remove KeyError assertion in tests due to PR in comment being merged
* [ADD] allow creating missing indexes * [FIX] tests; installation * [ADD] allow purging properties * [ADD] missing file * [ADD] test purging properties * [ADD] missing parent_id for menu entry * [FIX] don't delete too many and wrong properties
Using new base model inheritance.
[FIX] don't try to uninstall uninstalled modules [DEL] weird code [FIX] actually cleanup where we can
Update version number Use correct import Update .pot to match new syntax Adapt icon to fontawesome Add models description Rename field external id to new syntax <model>__<field>
cf discussion on OCA#1408
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-12.0/server-tools-12.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-database_cleanup/
Currently translated at 100.0% (74 of 74 strings) Translation: server-tools-12.0/server-tools-12.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-database_cleanup/pt_BR/
Currently translated at 51.4% (38 of 74 strings) Translation: server-tools-12.0/server-tools-12.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-database_cleanup/zh_CN/
Currently translated at 100.0% (74 of 74 strings) Translation: server-tools-12.0/server-tools-12.0-database_cleanup Translate-URL: https://translation.odoo-community.org/projects/server-tools-12-0/server-tools-12-0-database_cleanup/zh_CN/
damdam-s
force-pushed
the
15.0-mig-database_cleanup
branch
from
21dce2d
to
0ceacae
Compare
|
@damdam-s Can you check the tests? |
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
OCA-git-bot
added a commit
that referenced
this pull request
Jun 14, 2022
|
@gurneyalex your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-2219-by-gurneyalex-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Original 14.0 PR has been superseed by -> database_cleanup #2390 |
AungKoKoLin1997
suggested changes
Sep 26, 2022
| <field name="state">code</field> | ||
| <field name="model_id" ref="database_cleanup.model_cleanup_purge_wizard_menu" /> | ||
| <field name="code"> | ||
| action = env.get('cleanup.purge.wizard').get_wizard_action() |
There was a problem hiding this comment.
Suggested change
| action = env.get('cleanup.purge.wizard').get_wizard_action() | |
| action = env.get('cleanup.purge.wizard.menu').get_wizard_action() |
There was a problem hiding this comment.
I tested in local environment and get error "You are not allowed to create 'Purge stuff' (cleanup.purge.wizard) records." when click "Purge absolete menu entries". I think you should use the model of current menu.
|
Hello @damdam-s the 14.0 has been merged from another PR that superseeds the one you have been using. Do you have time to take a look at it? |
|
Superseded by #2547 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #1990