15.0 mig base exception fix #2319
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damdam-s
force-pushed
the
15.0-mig-base_exception_adhoc_fix
branch
2 times, most recently
from
9877b58
to
7150145
Compare
* Fix menu in base_exception * Fix base_exception/views/base_exception_view.xml
…lled by constraint methods 'detect_exception' can be called on an empty recordset.
Defines a new mechanism to build odoo classes that are only defined during testing.
- Show menu only to Exception Rule Managers - Use sequence and active widgets on tree view - Updated form to use sheet
… the _popup_exceptions mehtod
improve the perfs dramastically when there is a lot of records
No more empty fields after changing type.
Add a note about safe_eval
[IMP] Computed exception descriptions field, to display better help messages [IMP] Exceptions shouldn't be copied
This recently added feature is counter intuitive, error prone and is already causing bugs in sale_workflow.
The goal of the modified method is to create or remove the relationship (in the M2m relation tabel) between the tested model (such as sale_order) and the exception rules. When the ORM writes on ExceptionRule.sale_ids (using the example of sale_exception), it will first proceeds with these updates: * an UPDATE on exception_rule to set the write_date * INSERT or DELETE on the relation table * but then, as "write" is called on the exception rule, the ORM will trigger the api.depends to recompute all the "main_exception_ids" of the records (sales, ...) related to it, leading to an UPDATE for each sale order We end up with RowExclusiveLock on such records: * All the records of the relation table added / deleted for the current sale order * All the records of exception_rule matching the current sale order * All the records of sale_order related to the exception rules matching the current sale order The first one is expected, the next 2 are not. We can remove the lock on the exception_rule table by removing `_log_access`, however in any case, the main_exception_ids computed field will continue to lock many sale orders, effectively preventing 2 sales orders with the same exception to be confirmed at the same time. Reversing the write by writing on SaleOrder instead of ExceptionRule fixes the 2 unexpected locks. It should not result in more queries: the "to remove" part generates a DELETE on the relation table for the rule to remove and the "to add" part generates an INSERT for the rule to add, both will be exactly the same in both cases. Related to OCA#1642 Replaces OCA#1638
…ected exceptions (with test)
By default exceptions can be ignored by the click of a button. Users begin human they will just click that button what ever the internal rules. So this PR adds the option to set specific exceptions as blocking. When exceptions are detected if one of them is blocking, the user will not be able to ignore them.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-base_exception Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_exception/
damdam-s
force-pushed
the
15.0-mig-base_exception_adhoc_fix
branch
from
fafedc2
to
58d1b96
Compare
|
superseeds #2279 splits base_exception module in 2 modules:
I did that because model loading "on the fly" does not work |
This was referenced Mar 23, 2022
ivantodorovich
approved these changes
May 3, 2022
|
This PR has the |
|
When will this be merged ? |
leemannd
approved these changes
Jun 24, 2022
cesar-tecnativa
suggested changes
Jul 6, 2022
| super(TestBaseException, cls).setUpClass() | ||
| cls.loader = FakeModelLoader(cls.env, cls.__module__) | ||
| cls.loader.backup_registry() | ||
|
|
There was a problem hiding this comment.
do not remove tests
| ) | ||
|
|
||
| cls.exception_rule._fields["model"].selection.append( | ||
| ("base.exception.test.purchase.line", "Purchase Order Line") |
There was a problem hiding this comment.
do not remove tests
There was a problem hiding this comment.
I did a new PR #2366 that solves this problem
|
Superseded by #2366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tentative to fix #2279