Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] auditlog: Migration to 17.0 #2755

Merged
merged 165 commits into from
Apr 12, 2024
Merged

[17.0][MIG] auditlog: Migration to 17.0 #2755

merged 165 commits into from
Apr 12, 2024

Conversation

rven
Copy link
Contributor

@rven rven commented Nov 14, 2023

No description provided.

sebalix and others added 30 commits November 14, 2023 15:19
@sebalix @rven
[ADD] Module 'auditlog' - A substitute to the deprecated 'audittrail'…
58777c5 
… module
@sebalix @rven
[FIX] Module 'auditlog' - Fix some flake8 errors
390435f
@sebalix @rven
[FIX] Module 'auditlog' - Put the module description in a README.rst …
64f7fc3 
…file
@sebalix @rven
[ADD] Module 'auditlog' - 'auditlog.pot' file added
9333a70
@sebalix @rven
[IMP] Module 'auditlog' - Split the 'create_logs()' method in several…
e52c3b3 
… ones to make overridding easier
@sebalix @rven
[IMP] Module 'auditlog' - Clean up vim lines
ec089dd
@sebalix @rven
[IMP] Module 'auditlog' - Add 'name' attributes on some filters and o…
95b75b6 
…ther minor fixes
@sebalix @rven
[IMP] Module 'auditlog' - Removed the 'timestamp' field from the 'aud…
2ab70e9 
…itlog.log' model (standard 'create_date' field is used instead)
@sebalix @rven
[IMP] Module 'auditlog' - README.rst updated (based on the OCA template)
57e3c42
@sebalix @rven
[FIX] Module 'auditlog' - 'time' module imported but unused
dc24687
@hbrunn @rven
[IMP] ignore rules for nonexisting objects
1f812b7
@hbrunn @rven
[ADD] init hook to migrate from audittrail
63d343c
@hbrunn @rven
[FIX] also migrate id sequences
a247664
@sebalix @rven
[IMP] Module 'auditlog' - Contributors updated in README.rst + AUTHOR…
7ff0735 
…S.txt file removed
@hbrunn @rven
[ADD] change xmlids of legacy rules to point to auditlog.rule
abd6bd0
@hbrunn @rven
[IMP] use new import of _, SUPERUSER_ID
8a4f0b9
@hbrunn @rven
[ADD] allow overriding modules to pass additional log values
52c2e41
@hbrunn @rven
[IMP] cache model and field ids
5b3f7b4
@hbrunn @rven
[IMP] don't make a temporary copy of dict keys
8429b56
@hbrunn @rven
[FIX] don't reset caches in register_hook
8e00952
@hbrunn @rven
[ADD] pass old_values to create_log when deleting a record
e2369a6
@hbrunn @rven
[FIX] cope with no additional log values
23af1d3
@hbrunn @rven
[ADD] tests
e2cd564
@sebalix @rven
[FIX] Module 'auditlog' - local variable 'ir_model' is assigned to bu…
8412802 
…t never used
@hbrunn @rven
[IMP] use a model for test that is not influenced by the mail module
0b2dfdf
@sebalix @rven
[FIX] Module 'auditlog' - Remove 'active' field from __openerp__.py
7b0bf10
@sebalix @rven
[IMP] Module 'auditlog' - README.rst updated (inform that the audittr…
dbc0b1b 
…ail data - if any - are migrated during the installation)
@sebalix @rven
[IMP] Module 'auditlog' - Useless lines of code removed
11e8891
@sebalix @rven
[IMP] Module 'auditlog' - Autoremove 'auditlog.log.line' records when…
0ccef82 
… a field is deleted (e.g. migration)
@sebalix @rven
[IMP] Module 'auditlog' - Model 'auditlog.log.line', 'field_name' and…
81ee271 
… 'field_description' fields changed into related fields
@StefanRijnhart @rven
[FIX] auditlog: prevent removal of x2many values from inaccessible co…
1eb44b8 
…mpanies

Having a product.template with taxes from multiple companies assigned, let a
user without all of these companies enabled set the taxes of that product.

Before this change, the taxes related to inaccessible companies will be
inadvertently removed.

Co-authored-by: Raf Ven <[email protected]>
StefanRijnhart
StefanRijnhart approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@xFingerlinKx
Copy link

when will the version for 17 Odoo be available?

@StefanRijnhart
Copy link
Member

@xFingerlinKx as soon as more people have done a code review or a functional test. People like you!

@StefanRijnhart
Copy link
Member

@rven please check this fix of a regression introduced by the cache invalidation improvement: #2834

BT-anieto and others added 3 commits February 19, 2024 08:20
@BT-anieto @rven
[16.0][FIX] auditlog: Add/Remove User Group
12281f7 
When adding/removing a group in a user (and tracking a user or a partner), odoo sends a 'reified' val 'in_group_{group_id}'. We must convert this value into the real groups_id one.
@rven
[IMP] auditlog: pre-commit stuff
e5c2284
@rven
[MIG] auditlog: Migration to 17.0
dcab07e
@rven
Copy link
Contributor Author

rven commented Feb 19, 2024

@StefanRijnhart I added the specific commit into this PR, I had to change the test a little bit because of a ensure_one error.

@StefanRijnhart
Copy link
Member

@rven Great, thanks!

@nilshamerlinck nilshamerlinck mentioned this pull request Mar 11, 2024
Closed
@heccjj
Copy link

heccjj commented Mar 13, 2024 •
edited
Loading

Is this a bug?
I override the method do_print_picking() of stock.picking model, and there is code like this:
self.write({'printed': True})
Then add and subscribe stock.picking auditlog rule.
When I print a stock picking, I will get an empty log, without log_line!

@StefanRijnhart
Copy link
Member

@heccjj Your change does not seem substantial, you just leave out actually rendering the report. Therefore, I tested this on this PR's runbot, and I can't reproduce:

image

So it does not seem like a bug in the module. Perhaps there is some other customization in your setup that interferes here.

@heccjj
Copy link

heccjj commented Mar 14, 2024 •
edited
Loading

@StefanRijnhart Thanks for your reply. I try it again. If I print the picking slip first time, I get correct log, but if I print this picking slip again(field printed is already "True"), get an empty log.

@StefanRijnhart
Copy link
Member

@heccjj That makes sense, because the written values are only logged if the values differ from the current field values. The log is still present to represent the write itself (this is a design choice), but it is empty because there were no actual changes. So, not a bug.

DucTruongKomit
DucTruongKomit approved these changes Apr 12, 2024
View reviewed changes
Copy link

@DucTruongKomit DucTruongKomit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza
Copy link
Member

/ocabot merge nobump
/ocabot migration auditlog

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-2755-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ad29e1b into OCA:17.0 Apr 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8a35da0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

@DucTruongKomit DucTruongKomit DucTruongKomit approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.