Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] fetch...folder: use message uid's not sequence #3017

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

NL66278
Copy link
Contributor

@NL66278 NL66278 commented Aug 22, 2024

When archiving messages, the messages get a new sequence through renumbering. To solve the problems this causes use the message uid's that are garanteed to remain constant for a message within a folder.

@NL66278 NL66278 force-pushed the 16.0-fetchmail_attach_from_folder-use-uid branch from 4b32c32 to b6d4114 Compare August 22, 2024 15:00
@NL66278
Copy link
Contributor Author

NL66278 commented Aug 22, 2024

@zamberjo Can you have a look at this?

Copy link
Member

@zamberjo zamberjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically it seems correct, I have not been able to test it functionally.

Copy link

@anmarmo1 anmarmo1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not clear about the initial problem that this change solves, but, the initial functionality is still correct, so for me the change is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants