-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] session_db #3050
Open
sbidoul
wants to merge
32
commits into
OCA:18.0
Choose a base branch
from
acsone:18.0-mig-session_db-sbi
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[18.0][MIG] session_db #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upstream FilesystemSessionStore does not do that.
Retry on OperationalError exception, which we receive on database restart. Return cursor to pool when reconnecting.
There were concurrency issues in evented mode. So while I was at it, I added support for threaded mode too.
If the connection to the database fails when retrying a session operation, we end up with no cursore, which makes subsequent session operations fail. We fix this by ensuring we have cursor before any operations.
…gument 'max_lifetime'" when autovacuum gets executed. Signed-off-by: Christoph Fiehe <[email protected]>
It has been implemented.
/ocabot migration session_db |
sbidoul
force-pushed
the
18.0-mig-session_db-sbi
branch
from
October 7, 2024 12:49
1afa279
to
84395fe
Compare
The CI failed on WARNING 👍, |
sbidoul
force-pushed
the
18.0-mig-session_db-sbi
branch
from
October 7, 2024 12:53
84395fe
to
972358e
Compare
Tested manually 👍 |
qgroulard
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review)
sbidoul
force-pushed
the
18.0-mig-session_db-sbi
branch
from
October 7, 2024 14:00
972358e
to
7d2e3d8
Compare
or better, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.