Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] session_db #3050

Open
wants to merge 32 commits into
base: 18.0
Choose a base branch
from
Open

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Oct 7, 2024

No description provided.

nseinlet and others added 30 commits October 7, 2024 14:42
The upstream FilesystemSessionStore does not do that.
Retry on OperationalError exception, which we receive on database restart.
Return cursor to pool when reconnecting.
There were concurrency issues in evented mode.
So while I was at it, I added support for threaded mode too.
If the connection to the database fails when
retrying a session operation, we end up
with no cursore, which makes subsequent
session operations fail.

We fix this by ensuring we have cursor
before any operations.
…gument 'max_lifetime'" when autovacuum gets executed.

Signed-off-by: Christoph Fiehe <[email protected]>
It has been implemented.
@sbidoul sbidoul changed the title 18.0 mig session db sbi [18.0][MIG] session_db Oct 7, 2024
@sbidoul
Copy link
Member Author

sbidoul commented Oct 7, 2024

/ocabot migration session_db

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 7, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Oct 7, 2024
21 tasks
@sbidoul
Copy link
Member Author

sbidoul commented Oct 7, 2024

The CI failed on WARNING 👍, mute_logger to the rescue.

@sbidoul
Copy link
Member Author

sbidoul commented Oct 7, 2024

Tested manually 👍

Copy link

@qgroulard qgroulard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

@sbidoul
Copy link
Member Author

sbidoul commented Oct 7, 2024

mute_logger to the rescue

or better, self.assertLogs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants