Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] jsonifier: Migration to 18.0 #3053

Merged
merged 34 commits into from
Oct 10, 2024

Conversation

thienvh332
Copy link

@thienvh332 thienvh332 commented Oct 8, 2024

This PR includes two parts:

1. Sync:
Port of the following PRs from 14.0 to 17.0:

2. Migrate:
After syncing, migrated the jsonifier module to v18.

simahawk and others added 30 commits October 8, 2024 12:22
Rationale:

1. the name reflects better what it does
   as this is not _just_ a base module

2. solves publication issue on odoo apps store
   due to an old module registered w/ the same name
   that even if un-published blocks publishing the module
   for all versions.
   This in turn, blocks the publication of ALL modules
   that depend on base_jsonify.
We should always keep UTC and let the consumer deal w/ it.
This change is backward compatible but allows to turn off
the old behavior w/ the ctx flag `jsonifier__date_user_tz=False`.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-jsonifier
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-jsonifier/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-16.0/server-tools-16.0-jsonifier
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-jsonifier/
Currently translated at 100.0% (39 of 39 strings)

Translation: server-tools-16.0/server-tools-16.0-jsonifier
Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-jsonifier/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-tools-17.0/server-tools-17.0-jsonifier
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-jsonifier/
Currently translated at 100.0% (37 of 37 strings)

Translation: server-tools-17.0/server-tools-17.0-jsonifier
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-jsonifier/it/
Currently translated at 100.0% (37 of 37 strings)

Translation: server-tools-17.0/server-tools-17.0-jsonifier
Translate-URL: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-jsonifier/zh_CN/
Quite handy to take full control of the final result.
@thienvh332 thienvh332 marked this pull request as ready for review October 8, 2024 09:33
@thienvh332 thienvh332 mentioned this pull request Oct 8, 2024
21 tasks
@simahawk
Copy link
Contributor

simahawk commented Oct 9, 2024

/ocabot migration jsonifier

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Oct 9, 2024
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-3053-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bde7ecd into OCA:18.0 Oct 10, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 61209b7. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants