[18.0][MIG] mail_tracking: Migration to 18.0 #1476

trisdoan · 2024-10-17T05:07:17Z

Note

missing commits from 14.0 are ported in [17.0][FW] Port missing commits #1475

Big changes in 18.0

Backend

access_rights_uid was removed from _search() changed in odoo/odoo@21d023e
_prepare_outgoing_list got extra param mail_server in odoo/odoo@97ce084
_message_format was converted to use store and message_format_extras was removed in odoo/odoo@52df49e. As consequences, _extras_to_store is introduced
tools.ustr is considered to be inefficient and flagged as deprecated in odoo/odoo@64a5724. Hence, is replaced by exception_to_unicode for the same effect.

Frontend

mail.messaging service was removed in odoo/odoo@683258b
initMessagingCallback is removed in odoo/odoo@4f8087f. So new entry point is created for store onStarted instead.
mail.thread service was removed in odoo/odoo@65e5a79

This changes

Store helper was introduced in odoo/odoo@c032ccf. As consequences, failed data is now passed through Store.
- As a side effect, it is also easier to do the search filter_failed(thread) with Store service
As Odoo uses less Jquery, the module runs fine with vanilla. This impacts mail_tracking/static/src/components/message_tracking/message_tracking.esm.js
Took this chance to
- replace % format with f-string
- Improve permission constraint
  - Context: This commit porting from 12.0
  - Approach is summarized as below:
    1. When do the searching,
      - First, use the query to get result
      - Browse those id with the query + Remove any forbidden records
      - Return the accessible records in form of query, to continue the process
    2. When user read the records
      - The low-level method _check_access will discard forbidden records + raise exception
  - Added security check test
- Resolve FIXME, which was added in 7560443, then was resolved in odoo/odoo@7fe02c9

Result

* [ADD] mail_tracking addon * Add description icon * Fixes remarked * Fix Travis error * Remarks fixed

…ent events (OCA#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes

* Improve tests * Show trackings even if partner removed * Disable CSRF protection to webhooks controllers

…s and contacts to bounce (OCA#133)

…oved (OCA#132)

As regular users can't access this object.

* [FIX] Only one data-odoo-tracking-email tag in each email * [FIX] Get status even in multicompany instances

On our server, queries based on "mail_tracking_event"."tracking_email_id" improved from 501,924 ms to 1,840 ms queries based on "mail_tracking_email"."mail_message_id" improved from 167,436 ms to 3,223 ms The last ones are run several times when a thread has many messages

Currently translated at 100.0% (82 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/fr/

Closes OCA#303

For giving more priority to other buttons like the invoices one.

Currently translated at 96.3% (79 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/ca/

Or infinite recursions will happen on other `write` overwrites, like the one that happens on `mass_mailing_partner`.

Currently translated at 29.8% (34 of 114 strings) Translation: social-15.0/social-15.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_tracking/it/

Currently translated at 100.0% (125 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/fr/

TT49060

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/

Currently translated at 100.0% (128 of 128 strings) Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/

Add autovacuum to mail_tracking_email that removes old records based on new configuration variable mail_tracking_email_max_age_days. Due to possibly a large number of records to be deleted on first run, set a default limit of 5000 per run.

trisdoan · 2024-10-17T05:10:20Z

~~DRAFT: working on failed test~~

~~> 2024-10-17 05:08:43,628 246 WARNING odoo odoo.addons.mail_tracking.controllers.main: MailTracking email '11' not found~~

pedrobaeza · 2024-10-17T06:00:21Z

/ocabot migration mail_tracking

chienandalu

Huge work @trisdoan !

I should try with a real mail configuration. For the moment:

Installing the module in runboat doesn't load for me the demo failed messages for retry (I saw in them in your screenshot thou...)

chienandalu · 2024-10-17T07:01:06Z

mail_tracking/models/mail_message.py

@@ -29,7 +30,7 @@ class MailMessage(models.Model):
    )
    is_failed_message = fields.Boolean(
        compute="_compute_is_failed_message",
-        search="_search_is_failed_message",
+        store=True,


Do we really need to make it stored?

Hi, this flag is used to populate the controller: /mail/failed/messages

Please don't change how it was, no stored and with search method. Or does any reason for changing it?

Hi @pedrobaeza, yes I agree there is no need to store it in db. But look like the search method is not working.

I am working on it, will update when it's done

trisdoan · 2024-10-21T04:30:33Z

DRAFT: inspect _search_is_failed_message

pedrobaeza · 2024-10-21T18:52:42Z

What do you think about #1458 (comment) ?

antespi and others added 30 commits October 10, 2024 10:06

[8.0][ADD] mail_tracking addon (OCA#67)

196c6a1

* [ADD] mail_tracking addon * Add description icon * Fixes remarked * Fix Travis error * Remarks fixed

[8.0][IMP][mail_tracking] Speed installation time and discard concurr…

54f4f76

…ent events (OCA#82) [IMP] mail_tracking: Speed installation time, discard concurrent events and other fixes

[FIX] Update email_score when email changes

0a232c6

[MIG] mail_tracking

defd3c8

* Improve tests * Show trackings even if partner removed * Disable CSRF protection to webhooks controllers

[FIX] mail_tracking: Typo

3b9aac8

[MIG] Make modules uninstallable

9b53b4b

[MIG] mail_tracking: Migrated to 10.0

27569cd

[IMP] mail_tracking performance and bounce process (OCA#103)

33ebccb

[IMP] mail_tracking: Allow to define a custom mail_tracking base url

63dac84

Add access to portal/public user to his own email trackings

edd7af3

[8.0][FIX][mail_tracking] Use event recipient address to find partner…

f48a77f

…s and contacts to bounce (OCA#133)

[9.0][FIX][mail_tracking] Control exception when mail_message was rem…

1b9eb4c

…oved (OCA#132)

[FIX] Sender label is repeated in search fields

e9878c0

[FIX][9.0] partner buttons view on enterprise

51429ed

[FIX] mail_tracking: Obtain outgoing server with sudo

c9343c4

As regular users can't access this object.

[IMP] Shut mock exceptions up

2add73a

[9.0][IMP] mail_tracking: Improve view with error details

bfb1e36

[FIX] mail_tracking: bugfixes (OCA#199)

a727b92

* [FIX] Only one data-odoo-tracking-email tag in each email * [FIX] Get status even in multicompany instances

[FIX] mail_tracking js could break other modules using chat_manager

f742ef3

[MIG] mail_tracking: Migration to 11.0

34439fb

Translated using Weblate (French) [ci skip]

6918556

Currently translated at 100.0% (82 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/fr/

[IMP] mail_tracking: email score performance (OCA#299)

4b01aa2

Fix README.rst images not visible in GitHub and Odoo

d640c90

Closes OCA#303

[IMP] mail_tracking: Put button box at the end of the view

47d4555

For giving more priority to other buttons like the invoices one.

Translated using Weblate (Catalan)

3b81690

Currently translated at 96.3% (79 of 82 strings) Translation: social-11.0/social-11.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-11-0/social-11-0-mail_tracking/ca/

[MIG] mail_tracking: Migration to 12.0

d71f571

[FIX] mail_tracking: Don't call write inside other write

982d855

Or infinite recursions will happen on other `write` overwrites, like the one that happens on `mass_mailing_partner`.

[IMP] mail_tracking: Cc

f06ff90

[MIG] mail_tracking: Adapt Cc to 12.0

ae43ac1

mymage and others added 16 commits October 10, 2024 10:06

Translated using Weblate (Italian)

7e59260

Currently translated at 29.8% (34 of 114 strings) Translation: social-15.0/social-15.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_tracking/it/

Translated using Weblate (French)

5d53268

Currently translated at 100.0% (125 of 125 strings) Translation: social-16.0/social-16.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_tracking/fr/

[IMP] mail_tracking: Give example that actually works in readme

7887a5b

[FIX] mail_tracking: be closer to what Odoo does in a nodb environment

8b76617

[IMP] mail_tracking: pre-commit auto fixes

df5e46d

[MIG] mail_tracking: Migration to 17.0

2e77ed9

TT49060

[UPD] Update mail_tracking.pot

e4a3ea3

[BOT] post-merge updates

d832daf

Update translation files

cb6a40c

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/

Translated using Weblate (Italian)

46fd9c3

Currently translated at 100.0% (128 of 128 strings) Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/it/

[UPD] Update mail_tracking.pot

1250a02

Update translation files

b404006

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-17.0/social-17.0-mail_tracking Translate-URL: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_tracking/

[IMP] Add option to keep aliases in mail tracking

d72b1e1

mail_tracking: add garbage collection

b204171

Add autovacuum to mail_tracking_email that removes old records based on new configuration variable mail_tracking_email_max_age_days. Due to possibly a large number of records to be deleted on first run, set a default limit of 5000 per run.

[FW] port missing commits from 14.0 to 17.0

69d984d

[IMP] mail_tracking: pre-commit auto fixes

f9e9dbd

trisdoan mentioned this pull request Oct 17, 2024

Migration to version 18.0 #1458

Open

21 tasks

trisdoan marked this pull request as draft October 17, 2024 05:09

trisdoan mentioned this pull request Oct 17, 2024

[18.0][MIG] mail_tracking_mass_mailing: Migration to 18.0 #1478

Open

trisdoan marked this pull request as ready for review October 17, 2024 05:24

[MIG] mail_tracking: Migration to 18.0

794a168

trisdoan force-pushed the 18.0-mig-mail_tracking branch from df5d6c7 to 794a168 Compare October 17, 2024 05:24

OCA-git-bot added this to the 18.0 milestone Oct 17, 2024

pedrobaeza requested a review from chienandalu October 17, 2024 06:00

chienandalu reviewed Oct 17, 2024

View reviewed changes

trisdoan marked this pull request as draft October 21, 2024 04:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] mail_tracking: Migration to 18.0 #1476

[18.0][MIG] mail_tracking: Migration to 18.0 #1476

trisdoan commented Oct 17, 2024 •

edited

Loading

trisdoan commented Oct 17, 2024 •

edited

Loading

pedrobaeza commented Oct 17, 2024

chienandalu left a comment

chienandalu Oct 17, 2024

trisdoan Oct 18, 2024

pedrobaeza Oct 18, 2024

trisdoan Oct 21, 2024

trisdoan commented Oct 21, 2024

pedrobaeza commented Oct 21, 2024

[18.0][MIG] mail_tracking: Migration to 18.0 #1476

Are you sure you want to change the base?

[18.0][MIG] mail_tracking: Migration to 18.0 #1476

Conversation

trisdoan commented Oct 17, 2024 • edited Loading

Note

Big changes in 18.0

Backend

Frontend

This changes

Result

trisdoan commented Oct 17, 2024 • edited Loading

pedrobaeza commented Oct 17, 2024

chienandalu left a comment

Choose a reason for hiding this comment

chienandalu Oct 17, 2024

Choose a reason for hiding this comment

trisdoan Oct 18, 2024

Choose a reason for hiding this comment

pedrobaeza Oct 18, 2024

Choose a reason for hiding this comment

trisdoan Oct 21, 2024

Choose a reason for hiding this comment

trisdoan commented Oct 21, 2024

pedrobaeza commented Oct 21, 2024

trisdoan commented Oct 17, 2024 •

edited

Loading

trisdoan commented Oct 17, 2024 •

edited

Loading