[ADD] tms #130

max3903 · 2024-06-28T23:30:52Z

tms/models/res_partner.py

rousseldenis · 2024-07-17T07:46:30Z

tms/models/tms_order.py

+        raise ValidationError(_("You must create an TMS order stage first."))
+
+    @api.onchange("route")
+    def _onchange_route(self):


To adopt current Odoo approach, change these onchanges to computed stored readonly=False fields instead.

Can you send an example please?
What i'm trying to do is to empty the "route_id" field when I de-select the "route" boolean.

Yes, that flow is supported.

jbaudoux · 2024-07-17T08:50:58Z

tms/models/res_partner.py

+    latitude = fields.Float()
+    longitude = fields.Float()


Use partner_latitude from base

jbaudoux · 2024-07-17T08:54:00Z

tms/models/tms_vehicle.py

+    stage = fields.Char(related="stage_id.name")
+
+    # Relations
+    company_id = fields.Many2one("res.company", string="Company", default="")


fix default

jbaudoux · 2024-07-17T08:54:42Z

tms/models/tms_vehicle.py

+    driver_id = fields.Many2one("res.partner")
+
+    # Types
+    type = fields.Selection(selection=VEHICLE_TYPES)


I think this deserves a m2o instead of a selection
and rename to vehicule_type_id as type is a python class

tms/models/tms_vehicle.py

jbaudoux

Can you add the readme directory and explain the concepts of this module

pedrobaeza · 2024-07-17T14:34:41Z

Please remove the merge commits in the commit history.

rousseldenis · 2024-07-18T07:45:03Z

tms/models/tms_order.py

+    sequence = fields.Integer(default=10)
+
+    route = fields.Boolean(string="Use predefined route")
+    route_id = fields.Many2one("tms.route")


Suggested change

route_id = fields.Many2one("tms.route")

route_id = fields.Many2one("tms.route", compute="_compute_route_id", store=True, readonly=False)

@api.depends("route")

def _compute_route_id(self):

for order in self:

if not order.route_id and order.route_id:

order.route_id = False

@santiagordz

tms/__manifest__.py

tms/views/menu.xml

tms_sale/__manifest__.py

tms/__manifest__.py

tms/models/res_partner.py

tms/models/tms_vehicle.py

tms/pyproject.toml

tms/models/tms_stage.py

tms/views/menu.xml

marcelsavegnago

I believe that the TMS type can remain only in the TMS tab. Therefore, I don't see the need to add it next to the contact type.

marcelsavegnago · 2024-07-22T19:38:00Z

tms/models/tms_order.py

+    date_start = fields.Datetime(readonly=True)
+    date_end = fields.Datetime(readonly=True)
+    duration = fields.Float(readonly=True, string="Trip Duration")


how would these fields be handled in case maintenance is needed?

@marcelsavegnago If maintenance of the vehicle is needed, you would not be able to schedule a trip with that vehicle...

I'm referring to data maintenance. From what I understand, the start and end of the trip are recorded when the 'Start' and 'End' buttons are clicked. Therefore, if someone doesn't click 'Start' or 'Finish', we would need to change the recorded values.

rvalyi · 2024-07-25T15:48:16Z

@max3903 @rousseldenis @marcelsavegnago with the https://github.com/akretion/xsdata-odoo tool I presented at the OCA days 2021, you could quite easily generate all the Odoo data model for the UBL transport management entities:
https://docs.oasis-open.org/ubl/os-UBL-2.3/UBL-2.3.html#S-INTERMODAL-FREIGHT-MANAGEMENT

Aside from having a universally accepted and standard data model, it would also make it a piece of cake to have import and export of UBL XML documents for it...

Wouldn't that be preferable over bootstrapping a custom data model from scratch where all messaging mapping would need to be made and maintained manually?

Again, for reference here is the kind of Abstract Odoo mixins it generates from xsd schemas, here for the Brazilian Electronic Invoicing (the most complex in the world):
https://github.com/OCA/l10n-brazil/blob/16.0/l10n_br_nfe_spec/models/v4_0/leiaute_nfe_v4_00.py

For UBL, I may need to do small adaptations to xsdata-odoo to properly map the UBL intermediaries simple types to proper Odoo field types (I already started, it's not a lot of work.).

Disclaimer: may be the UBL Transport entities are not adapted to what you are trying to manage, but I believe it's pretty close to what @marcelsavegnago is dealing with for the Brazilian CT-e electronic documents. In this case, @marcelsavegnago is actually already using this datamodel generated by xsdata-odoo for the xsd CT-e Brazilian fiscal model https://github.com/OCA/l10n-brazil/tree/14.0/l10n_br_cte_spec/models/v4_0
But eventually UBL is a match for what you need, so I'm just mentioning the possibility.

What do you guys think?

(I'm also available for hire if you need a few days of work to make it work with that UBL schema properly)

pedrobaeza · 2024-09-03T06:42:42Z

@max3903 you must use the ocabot command instead of manually merging branches. There's no approval from the reviewers here either. Please refrain from merging without these conditions.

rousseldenis · 2024-09-03T07:04:42Z

@max3903 I agree with @pedrobaeza. This is a little bit cavalier...

rousseldenis · 2024-09-03T07:25:31Z

@OCA/logistics-maintainers

rousseldenis · 2024-09-03T07:29:01Z

IMHO, some reviews comments should have been attended.

Partner model has been overcharged with a lot of fields that should have been put elsewhere or renamed. Why not having created a new model that inherits from res.partner (or at least having partner_id field) ?
Onchanges should have been removed.

simahawk

Indeed, there's no approval, there's a blocking review... This should not have been merged, especially since the PR is not stale. You were not waiting for reviewers feedback since weeks. Even if this module is alpha.

Now, if this is a way to speed up the work on all the other related PRs and to reduce the effort here, I understand your hurry but you should at least mention how you intend to follow up from here (you could have added TODOs in the code or add a roadmap for instance).

Also changes to dotfiles were committed together w/ module's changes which will cause conflicts when porting the 1st commit to other branches... 🙈

As this is the only module available in 17.0 and there's no pending PR if not yours and nobody is using this yet, we could even rewrite the history of this branch.

My $0.02

simahawk · 2024-09-03T10:47:08Z

tms/tests/test_fleet_vehicle.py

+from odoo.tests.common import TransactionCase
+
+
+class TestFleetVehicle(TransactionCase):


You should use BaseCase everywhere when tracking is not needed.
setUp code should be moved to setUpClass unless is really needed to run something before every test runs.

rousseldenis · 2024-09-03T12:14:51Z

As this is the only module available in 17.0 and there's no pending PR if not yours and nobody is using this yet, we could even rewrite the history of this branch.

Agree with that

rousseldenis · 2024-09-06T07:02:59Z

@OCA/core-maintainers Could we reset the 17.0 branch ?

@max3903 Could you do after that a better PR? Even if it is Alpha, some conventions should be respected at least. Many thanks

max3903 · 2024-09-17T22:48:03Z

Hello,

Sorry for the late answer, I was on vacation during the last 2 weeks.

@EdgarRetes will take care of the requested changes. I would like to get this merged prior to OCA Days to present it and to start migration to version 18.0 while in Belgium.

rousseldenis · 2024-09-18T07:09:44Z

I would like to get this merged prior to OCA Days to present it and to start migration to version 18.0 while in Belgium.

Ok, with that, but not at any price. Please respect OCA flows and requirements.

@simahawk Could you restore 17.0 branch?

@max3903 This will need a new PR for tms module.

I can help with review before OCA days.

simahawk · 2024-09-18T08:57:49Z

Here's a clean 17.0 branch reset to the commit before the module was introduced https://github.com/OCA/stock-logistics-transport/tree/17.0

Here's a backup of the 17.0 before the reset because translations have been added... in case you want to cherry-pick them

https://github.com/OCA/stock-logistics-transport/commits/17.0-tms-backup/

Let me know when is not needed anymore and I'll delete it.

rousseldenis · 2024-09-18T09:03:01Z

Here's a clean 17.0 branch reset to the commit before the module was introduced https://github.com/OCA/stock-logistics-transport/tree/17.0

Here's a backup of the 17.0 before the reset because translations have been added... in case you want to cherry-pick them

https://github.com/OCA/stock-logistics-transport/commits/17.0-tms-backup/

Let me know when is not needed anymore and I'll delete it.

thanks!

@EdgarRetes Could you recreate the PR from your ursais:17.0_tmsbranch ? Thanks

EdgarRetes · 2024-09-18T17:48:16Z

Here's a clean 17.0 branch reset to the commit before the module was introduced https://github.com/OCA/stock-logistics-transport/tree/17.0
Here's a backup of the 17.0 before the reset because translations have been added... in case you want to cherry-pick them
https://github.com/OCA/stock-logistics-transport/commits/17.0-tms-backup/
Let me know when is not needed anymore and I'll delete it.

thanks!

@EdgarRetes Could you recreate the PR from your ursais:17.0_tmsbranch ? Thanks

Done! #145

max3903 added enhancement help wanted needs review work in progress labels Jun 28, 2024

max3903 added this to the 17.0 milestone Jun 28, 2024

rousseldenis reviewed Jul 1, 2024

View reviewed changes

tms/models/res_partner.py Outdated Show resolved Hide resolved

rousseldenis reviewed Jul 17, 2024

View reviewed changes

jbaudoux reviewed Jul 17, 2024

View reviewed changes

tms/models/tms_vehicle.py Outdated Show resolved Hide resolved

jbaudoux reviewed Jul 17, 2024

View reviewed changes

pedrobaeza mentioned this pull request Jul 17, 2024

RFC: Transportation Management System #127

Open

16 tasks

rousseldenis reviewed Jul 18, 2024

View reviewed changes

max3903 commented Jul 18, 2024

View reviewed changes

tms/__manifest__.py Show resolved Hide resolved

max3903 commented Jul 18, 2024

View reviewed changes

tms/views/menu.xml Outdated Show resolved Hide resolved

max3903 commented Jul 18, 2024

View reviewed changes

tms_sale/__manifest__.py Outdated Show resolved Hide resolved

max3903 removed help wanted work in progress labels Jul 19, 2024

max3903 self-assigned this Jul 19, 2024

max3903 commented Jul 19, 2024

View reviewed changes

tms/__manifest__.py Outdated Show resolved Hide resolved

max3903 commented Jul 19, 2024

View reviewed changes

tms/models/res_partner.py Outdated Show resolved Hide resolved