[ADD][17.0] tms_expense

[EdgarRetes]

No description provided.

[EdgarRetes]

@max3903, please check this

[douglascstd]

[FUNCTIONAL REVIEW]

Problem 1:
I attempted to split an expense that I started to insert into a trip:

UncaughtPromiseError > OwlError
Uncaught Promise > The following error occurred in onWillStart: ""hr.expense.split.wizard"."state" field is undefined."

This error does not occur when trying to split an expense started from the "My Expense" menu:

Situation 1: Possibility to create a new trip from an expense:

It is not possible to link to an existing trip. In my example, I created an expense (Fuel) and split it into several trips.

Situation 2: Filter expenses to know if there is a trip vinculated.

Sugestion is insert a field in the hr.expense form:

<xpath expr="//field[@name='product_id']" position="after">
  <field name="trip_id" string="Trip"/>
</xpath>

[marcelsavegnago]

This data can be obtained from the partner associated with the employee.

[marcelsavegnago]

Here, I also believe that there is no need to create a new field. You can probably retrieve this based on the existing data.

[marcelsavegnago]

Maybe search for the partner in employee_id.address_home_id (where address_home is a res.partner) or, if it is a user, get the employee_id and partner_id linked to the user.

[marcelsavegnago]

    employee_id = fields.Many2one('hr.employee', string='Driver', compute='_compute_employee_id', store=True)

    @api.depends('driver_id')
    def _compute_employee_id(self):
        for record in self:
            record.employee_id = self.env['hr.employee'].search([('user_partner_id', '=', record.driver_id.id)], limit=1)
            if not record.employee_id:
                record.employee_id = self.env['hr.employee'].search([('address_home_id', '=', record.driver_id.id)], limit=1)