[16.0][ADD] shipment_advice_planner #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbejaoui
force-pushed
the
16.0-shipment_advice_planner-sbj
branch
5 times, most recently
from
84f8ca8
to
b1480f2
Compare
|
cc/ @lmignon |
|
@sbejaoui Thanks for this. Don't forget to put your dependencies links in your PR description to help reviewers. |
lmignon
suggested changes
Feb 13, 2023
sbejaoui
force-pushed
the
16.0-shipment_advice_planner-sbj
branch
from
b1480f2
to
2792a23
Compare
lmignon
reviewed
Feb 13, 2023
lmignon
approved these changes
Feb 13, 2023
sbejaoui
force-pushed
the
16.0-shipment_advice_planner-sbj
branch
3 times, most recently
from
7e1c4fa
to
5b11c92
Compare
lmignon
approved these changes
Feb 14, 2023
sbejaoui
force-pushed
the
16.0-shipment_advice_planner-sbj
branch
from
5b11c92
to
2970f90
Compare
|
@lmignon , please check my last commit. It adds warehouse and dock to the planner with some data consistency checks. |
lmignon
approved these changes
Feb 15, 2023
This was referenced Feb 15, 2023
lmignon
approved these changes
Feb 23, 2023
simahawk
changed the title
lmignon
force-pushed
the
16.0-shipment_advice_planner-sbj
branch
2 times, most recently
from
0ccee46
to
1b5e1e6
Compare
|
@rousseldenis @jbaudoux This one is ready for review and then merge 👼 |
sbejaoui
force-pushed
the
16.0-shipment_advice_planner-sbj
branch
4 times, most recently
from
ae2bfc0
to
0239264
Compare
jbaudoux
reviewed
Aug 18, 2023
jbaudoux
reviewed
Aug 18, 2023
jbaudoux
requested changes
Aug 18, 2023
|
@sbejaoui Could you look at comments ? |
sbejaoui
force-pushed
the
16.0-shipment_advice_planner-sbj
branch
2 times, most recently
from
4205437
to
46a04c9
Compare
|
Great contribution! @moduon testit |
jbaudoux
reviewed
Sep 1, 2023
cyrilmanuel
approved these changes
Sep 25, 2023
sbejaoui
force-pushed
the
16.0-shipment_advice_planner-sbj
branch
from
0f0186c
to
2e237b6
Compare
This module is used to plan ready transfers in shipment advices. As this is the base module, it provides only a simple: Transfers are grouped to have a single shipment advice by warehouse. [IMP] shipment_advice_planner: Add init script [FIX] - shipment_advice_planner: fix typo [FIX] - group pickings to plan by picking type instead of the warehouse [IMP] - shipment_advice_planner: add search for can_be_planned_in_shipment_advice field [IMP] shipment_advice_planner: shipment advice is created confirmed and arrival and departure date [IMP] - shipment_advice_planner: add unit tests [IMP] shipment_advice_planner: add author & maintainer Co-authored-by: Jacques-Etienne Baudoux <[email protected]> [IMP] add depends_context to _compute_picking_to_plan_ids
sbejaoui
force-pushed
the
16.0-shipment_advice_planner-sbj
branch
from
2e237b6
to
7d36e2d
Compare
|
@rousseldenis , |
simahawk
approved these changes
Oct 5, 2023
| @@ -0,0 +1,3 @@ | |||
| from . import common | |||
There was a problem hiding this comment.
no need to import common in any test suite
simahawk
reviewed
Oct 5, 2023
| @@ -0,0 +1,2 @@ | |||
| * Souheil Bejaoui <[email protected]> | |||
| * Laurent Mignon <[email protected]> | |||
This was referenced Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is used to plan ready transfers in shipment advices.
As this is the base module, it provides only a simple
planning mode. Transfers are grouped to have a single shipment advice by warehouse.