Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] stock_picking_invoice_link #513

Merged
merged 31 commits into from
Apr 10, 2019

Conversation

AdriaGForgeFlow
Copy link
Contributor

Standard migration of module stock_picking_invoice_link to v12

eLBati and others added 30 commits March 29, 2019 08:29
partially by creating i18n folder first
In order to get visibility on https://www.odoo.com/apps the OCA board has
decided to add the OCA as author of all the addons maintained as part of the
association.
… is cancelled its pickings go back to "to2invoiced" state * If a cancelled invoice goes back again to draft, its pickings are marked as invoiced to avoid invoicing twice * Not able to erase an invoice with pickings not cancelled * Tests

stock_picking_invoice_link: unlink improved * enable erasing when invoice is in state 'draft' or 'cancel' * if invoice is in state 'draft', not cancelled picking will be invoiceable
… references

For dropshipping pickings with module stock_dropshipping_dual_invoice, you generate
two invoices for the same picking, so the many2one only reflects the last generated
invoice. With this change, now both are linked.
…#296)

Previous migration did not keep the business functionality of the previous module. Link from invoice to picking must link only related delivery and not all deliveries in case of partial delivery
avoiding 'product.service_delivery' because not useful in tests and correctly handled as service by 10.0 tests
@pedrobaeza pedrobaeza added this to the 12.0 milestone Mar 29, 2019
@pedrobaeza
Copy link
Member

There's already #470

@AdriaGForgeFlow AdriaGForgeFlow deleted the 12.0-mig-stock_picking_invoice_link branch March 29, 2019 10:31
@rousseldenis
Copy link
Contributor

Uh that's me or sale != invoice ? 😄

@pedrobaeza
Copy link
Member

What do you mean, @rousseldenis ?

@AdriaGForgeFlow AdriaGForgeFlow restored the 12.0-mig-stock_picking_invoice_link branch March 29, 2019 10:33
@AdriaGForgeFlow
Copy link
Contributor Author

@pedrobaeza The PR you referenced is the migration of stock_picking_sale_order_link, this one is the migration of stock_picking_invoice_link

@rousseldenis
Copy link
Contributor

@pedrobaeza wrong ref in migration issue

@pedrobaeza
Copy link
Member

Ouch, the problem was on the migration issue (but probably on my side too):

Selección_022

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 29, 2019
34 tasks
Copy link
Member

@luismontalba luismontalba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@pedrobaeza pedrobaeza merged commit 0c82972 into OCA:12.0 Apr 10, 2019
@LoisRForgeFlow LoisRForgeFlow deleted the 12.0-mig-stock_picking_invoice_link branch April 11, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.