Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] stock_quant_package_product_packaging #607

Merged
merged 3 commits into from
May 28, 2020
Merged

[13.0][MIG] stock_quant_package_product_packaging #607

merged 3 commits into from
May 28, 2020

Conversation

grindtildeath
Copy link
Contributor

Forward port of #585

@grindtildeath grindtildeath mentioned this pull request Jan 8, 2020
Merged
2 tasks
@rousseldenis rousseldenis added this to the 13.0 milestone Jan 9, 2020
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 9, 2020
Closed
36 tasks
@rousseldenis
Copy link
Contributor

@grindtildeath isn't it time to add tests ?

@grindtildeath
Copy link
Contributor Author

@rousseldenis I'll try to add a few here if I still have time after migrating the "top modules" from wms repo 😉

@grindtildeath grindtildeath force-pushed the 13.0-mig-stock_quant_package_product_packaging branch from cfcf10b to c1c1ec6 Compare January 13, 2020 17:14
simahawk
simahawk reviewed Mar 20, 2020
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grindtildeath still have to work on this?

stock_quant_package_product_packaging/models/stock_quant_package.py
pack_products = pack.quant_ids.mapped("product_id")
if len(pack_products) == 1:
pack.single_product_id = pack_products.id
# TODO handle uom
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this TODO a blocker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at it now, I think the comment can be dropped because:

Copy link
Contributor

@simahawk simahawk May 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. Remove it then :)

@grindtildeath grindtildeath force-pushed the 13.0-mig-stock_quant_package_product_packaging branch from 37b1b54 to 06d45a8 Compare March 23, 2020 12:34
@grindtildeath
# This is a combination of 3 commits.
e2c68b7 
# This is the 1st commit message:

Add module stock_quant_package_product_packaging

# The commit message #2 will be skipped:

# Add tests

# The commit message OCA#3 will be skipped:

# Display single_product fields in debug mode
@grindtildeath
[IMP] stock_quant_package_product_packaging: black, isort
13ba6c1
@grindtildeath grindtildeath force-pushed the 13.0-mig-stock_quant_package_product_packaging branch from 8863cbf to b9481ed Compare March 23, 2020 13:46
@grindtildeath grindtildeath force-pushed the 13.0-mig-stock_quant_package_product_packaging branch from b9481ed to 3f7e2ef Compare March 23, 2020 13:46
simahawk
simahawk approved these changes May 6, 2020
View reviewed changes
stock_quant_package_product_packaging/models/stock_quant_package.py
pack_products = pack.quant_ids.mapped("product_id")
if len(pack_products) == 1:
pack.single_product_id = pack_products.id
# TODO handle uom
Copy link
Contributor

@simahawk simahawk May 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. Remove it then :)

@simahawk
Copy link
Contributor

simahawk commented May 6, 2020

@grindtildeath check commits, this is likely an error e2c68b7

@simahawk simahawk self-requested a review May 6, 2020 06:12
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@jgrandguillaume
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-607-by-jgrandguillaume-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 120df39 into OCA:13.0 May 28, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5d95154. Thanks a lot for contributing to OCA. ❤️

@jgrandguillaume jgrandguillaume mentioned this pull request May 28, 2020
Closed
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tonow-c2c Tonow-c2c Tonow-c2c approved these changes

@simahawk simahawk Awaiting requested review from simahawk

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@grindtildeath @rousseldenis @simahawk @OCA-git-bot @jgrandguillaume @Tonow-c2c