Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0] [MIG] stock_picking_operation_quick_change: Migration to v13.0 #845

Merged

Conversation

CarlosRoca13
Copy link
Contributor

cc @Tecnativa TT27875

please @joao-p-marques @victoralmau review this

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK, only some little changes.

@@ -0,0 +1,15 @@
# © 2017 Sergio Teruel <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# © 2017 Sergio Teruel <[email protected]>
# © 2017 Tecnativa - Sergio Teruel

@@ -0,0 +1,157 @@
# © 2017 Sergio Teruel <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# © 2017 Sergio Teruel <[email protected]>
# © 2017 Tecnativa - Sergio Teruel

@@ -0,0 +1,20 @@
<?xml version="1.0" encoding="utf-8" ?>
<!-- Copyright 2017 Sergio Teruel <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Copyright 2017 Sergio Teruel <[email protected]>
<!-- Copyright 2017 Tecnativa - Sergio Teruel

@@ -0,0 +1,103 @@
# © 2017 Sergio Teruel <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# © 2017 Sergio Teruel <[email protected]>
# © 2017 Tecnativa - Sergio Teruel


@api.model
def default_get(self, fields):
res = super(StockPickingOperationWizard, self).default_get(fields)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res = super(StockPickingOperationWizard, self).default_get(fields)
res = super().default_get(fields)

@@ -0,0 +1,53 @@
<?xml version="1.0" encoding="utf-8" ?>
<!-- Copyright 2017 Sergio Teruel <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Copyright 2017 Sergio Teruel <[email protected]>
<!-- Copyright 2017 Tecnativa - Sergio Teruel

@CarlosRoca13 CarlosRoca13 force-pushed the 13.0-MIG-stock_picking_operation_quick_change branch from 391f3b3 to 14120d4 Compare May 20, 2021 06:04
@CarlosRoca13
Copy link
Contributor Author

@victoralmau changes done

Copy link
Member

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Waiting for runbot for functional review 😅

move_lines = self.picking.mapped("move_line_ids")
self.assertEqual(wiz.location_dest_id, self.picking.location_dest_id)
self.assertEqual(wiz.old_location_dest_id, move_lines[:1].location_dest_id)
wiz.action_apply()
move_lines = self.picking.mapped("move_line_ids.location_dest_id")
self.assertEqual(len(move_lines), 1)

def test_picking_operation_change_location_dest(self):
def _test_picking_operation_change_location_dest(self):
Copy link
Member

@joao-p-marques joao-p-marques May 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these tests meant to be skipped?

@@ -129,7 +139,7 @@ def test_picking_operation_change_location_dest(self):
move_lines = self.picking.mapped("move_line_ids.location_dest_id")
self.assertEqual(len(move_lines), 2)

def test_picking_operation_change_location_dest_failed(self):
def _test_picking_operation_change_location_dest_failed(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here as above

@CarlosRoca13 CarlosRoca13 force-pushed the 13.0-MIG-stock_picking_operation_quick_change branch from 14120d4 to 39d2d3a Compare May 20, 2021 06:23
@CarlosRoca13
Copy link
Contributor Author

UPS sorry, changed @joao-p-marques

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-845-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 369d22f into OCA:13.0 May 24, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at eb91989. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.