[14.0][MIG] - stock_auto_move #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional argument no_prepare
* The `_apply` method should not be overridden. In case of three step operation with the last step set to auto move. The override of the `_apply` method was causing the second move to be automatic as well. **Use case**: doing a reception operation in two steps where the moves on the second step are set to be automatic (using the push rule in this case), and the reception is done partially. **Expected Result**: When doing a first reception step partially a back order is created, and we expect the second step to have a back order for the remaining qty as well. **Current behavior**: The correct move is processed automatically but no backorder is created. The reason for that behavior is we processing the move directly (i.e calling `action_done` of the `stock.move`) without going through the normal process (i.e processing the second step picking). **The solution to the problem**: The processing the of the automatic stock move should follow the same behavior as done from the user interface. I've added a new function in `stock.picking` model called `_transfer_pickings_with_auto_move` to simulate the same behavior this function is called inside the `action_assign` of the stock move instead of calling the `action_done` of the move.
As in v>=12, stock.location.path and procurement.rule have been merged into stock.rule, use the same field name.
If moves were created with a particular procurment group, don't change it to automatic one. Do it only if it's void.
As unit of measure can be a different multiple than reference, use product_uom_qty instead.
If in a first picking, we transfer partially one quantity and say 'No backorder', the destination move should be split and cancelled for the remaining quantities if 'propagate_cancel' is set.
… (take2) In case of partial flows with move cancel and mixed moves (auto and manual), we need to create a backorder for manual quantities to not get a picking with moves with mixed states (done, cancel, assigned). We remove code that is never called on picking side
|
cc/ @rousseldenis |
sbejaoui
force-pushed
the
14.0-stock_auto_move-sbj
branch
from
adeec2f
to
5c6b046
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
This PR has the |
|
Congratulations, your PR was merged at eb28775. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FW #735