Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] product_supplierinfo_for_customer_picking: Migration to 13.0 #957

Merged
merged 13 commits into from
Feb 1, 2022
Merged

[MIG] product_supplierinfo_for_customer_picking: Migration to 13.0 #957

merged 13 commits into from
Feb 1, 2022

Conversation

PabloPaezSheridan
Copy link

No description provided.

AaronHForgeFlow and others added 12 commits January 25, 2022 09:52
@AaronHForgeFlow
[UPT] rename module and minor fixes
31ae4f8
@MiquelRForgeFlow
[ADD] Tests
d2800c3
@oca-travis
[UPD] Update product_supplierinfo_for_customer_picking.pot
00cadee
@OCA-git-bot
[ADD] icon.png
f4f2def
@MiquelRForgeFlow
[MIG] product_supplierinfo_for_customer_picking: Migration to 12.0
f170e92
@oca-travis
[UPD] Update product_supplierinfo_for_customer_picking.pot
f4e2a48
@OCA-git-bot
[UPD] README.rst
4be350a
@oca-transbot
Update translation files
9736e84 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-product_supplierinfo_for_customer_picking
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-product_supplierinfo_for_customer_picking/
@oca-transbot
Update translation files
25e84a6 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-product_supplierinfo_for_customer_picking
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-product_supplierinfo_for_customer_picking/
@marcelsavegnago
Added translation using Weblate (Portuguese (Brazil))
49359d1
@fcolus
Translated using Weblate (Portuguese (Brazil))
e2d6904 
Currently translated at 100.0% (2 of 2 strings)

Translation: stock-logistics-workflow-12.0/stock-logistics-workflow-12.0-product_supplierinfo_for_customer_picking
Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-workflow-12-0/stock-logistics-workflow-12-0-product_supplierinfo_for_customer_picking/pt_BR/
[IMP] : black, isort, prettier
519f96e
@PabloPaezSheridan PabloPaezSheridan mentioned this pull request Jan 25, 2022
Closed
36 tasks
@MiquelRForgeFlow
Copy link
Contributor

In your PR title and also in last commit message should put "13.0" instead of "14.0" hehe

@PabloPaezSheridan
Copy link
Author

In your PR title and also in last commit message should put "13.0" instead of "14.0" hehe

@MiquelRForgeFlow changed, yes that commit is a cherry-pick from the migration to 14.0

MiquelRForgeFlow
MiquelRForgeFlow approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to edit the title also 😉

product_supplierinfo_for_customer_picking/readme/CONTRIBUTORS.rst Outdated Show resolved Hide resolved
...ct_supplierinfo_for_customer_picking/tests/test_product_supplierinfo_for_customer_picking.py Outdated Show resolved Hide resolved
@PabloPaezSheridan PabloPaezSheridan changed the title [MIG] product_supplierinfo_for_customer_picking: Migration to 14.0 [MIG] product_supplierinfo_for_customer_picking: Migration to 13.0 Jan 25, 2022
@PabloPaezSheridan PabloPaezSheridan force-pushed the 13.0-h-46330-pp branch 2 times, most recently from 0298805 to f6a7bc0 Compare January 26, 2022 15:37
@PabloPaezSheridan
Copy link
Author

@rousseldenis Hi, can you take a look on this PR? we need this merged for our clients. thank you

@rousseldenis
Copy link
Contributor

@rousseldenis Hi, can you take a look on this PR? we need this merged for our clients. thank you

Usually, the OCA flow needs at least 5 days (if no maintainer approves it) before PR merge.

Could you fix pre-commit ?

@rousseldenis
Copy link
Contributor

/ocabot migration product_supplierinfo_for_customer_picking

@OCA-git-bot OCA-git-bot added this to the 13.0 milestone Jan 26, 2022
nicomacr
nicomacr approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@nicomacr nicomacr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PabloPaezSheridan
Copy link
Author

@rousseldenis now is all green :)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis
rousseldenis approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. Small comment

@PabloPaezSheridan
Copy link
Author

@rousseldenis all done

@PabloPaezSheridan
Copy link
Author

@rousseldenis denis we need this for our clients, is anything pending to merge this? tell me if you need any change

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 13.0-ocabot-merge-pr-957-by-rousseldenis-bump-patch, awaiting test results.

@rousseldenis
Copy link
Contributor

Done 😃

@rousseldenis denis we need this for our clients

I don't know your flows but I suppose you can integrate your branch for deployments?

@OCA-git-bot OCA-git-bot merged commit 47f143c into OCA:13.0 Feb 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3fc563e. Thanks a lot for contributing to OCA. ❤️

@nicomacr nicomacr deleted the 13.0-h-46330-pp branch February 1, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicomacr nicomacr nicomacr approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@MiquelRForgeFlow MiquelRForgeFlow MiquelRForgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.