-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow the user to archive the reports when printing them #28
base: 7.0
Are you sure you want to change the base?
Conversation
Is this specific to webkit. If not, better put it on OCA/reporting-engine. |
…it-tools into 7.0-allow-report-archiving
Hey @BT-jmesa, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
…g here causing to stop the execution of the function
Hey @BT-jmesa,
Appreciation of efforts, |
it seems like the travis check is broken: |
@pedrobaeza @dreispt |
I asked about the specificity of the module and that is better to put it on OCA/reporting-engine. |
okay, even if the module is webkit specific and has a dependency to report_webkit? |
…ions. Dependency missing?
return __create_pdf | ||
|
||
|
||
WebKitParser.create = __new_create(WebKitParser.create) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't we use Odoo's regular method extension?
AFAICS the implementation seems generic enough to support other reports engines other than Webkit (QWeb). Any reason to specifically exclude QWeb? |
No description provided.