Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to archive the reports when printing them #28

Open
wants to merge 17 commits into
base: 7.0
Choose a base branch
from
Open

Allow the user to archive the reports when printing them #28

wants to merge 17 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 23, 2015

No description provided.

@pedrobaeza
Copy link
Member

Is this specific to webkit. If not, better put it on OCA/reporting-engine.

@oca-clabot
Copy link

Hey @BT-jmesa, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/website.cla
Here is a list of the users:

  • @BT-kaberer (login unknown in OCA database)
  • @BT-jmesa (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

@dreispt dreispt added this to the 7.0 milestone Mar 11, 2016
@oca-clabot
Copy link

Hey @BT-jmesa,
We acknowledge that the following users have signed our Contributor License Agreement:

  • @BT-kaberer

Appreciation of efforts,
OCA CLAbot

@ghost
Copy link
Author

ghost commented Mar 14, 2016

it seems like the travis check is broken:
couldn't execute "/home/travis/odoo-7.0/openerp-server": no such file or directory

@ghost
Copy link
Author

ghost commented May 9, 2017

@pedrobaeza @dreispt
Can you merge this PR or are changes needed? Thank you 👍
It's a simple webkit extension to save report PDF's to a folder

@pedrobaeza
Copy link
Member

I asked about the specificity of the module and that is better to put it on OCA/reporting-engine.

@ghost
Copy link
Author

ghost commented May 9, 2017

okay, even if the module is webkit specific and has a dependency to report_webkit?

return __create_pdf


WebKitParser.create = __new_create(WebKitParser.create)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't we use Odoo's regular method extension?

@dreispt
Copy link
Member

dreispt commented Jul 12, 2017

AFAICS the implementation seems generic enough to support other reports engines other than Webkit (QWeb). Any reason to specifically exclude QWeb?
If use use regular method extension you could even drop the Webkit dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants