[17.0][MIG] website_odoo_debranding Migration to 17.0

[NICO-SOLUTIONS]

Standard migration to 17.0

[pedrobaeza]

/ocabot migration website_odoo_debranding

[astirpe]

Tested in runboat and code review ok

[AaronHForgeFlow]

Functional

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[astirpe]

There's an error when installing this module and afterwards installing enterprise module planning:

Element '<xpath expr="//t[@t-call=&#39;web.brand_promotion_message&#39;]">' cannot be located in parent view

[NICO-SOLUTIONS]

There's an error when installing this module and afterwards installing enterprise module planning:

Element '<xpath expr="//t[@t-call=&#39;web.brand_promotion_message&#39;]">' cannot be located in parent view

good catch!
when installing planning, web.brand_promotion will be replaced by planning.brand_promotion. I´ll check xpathing another element...

[NICO-SOLUTIONS]

@astirpe
i think in this case switching back to inherit the web module is the better approach.
As we need to keep...
t t-call="web.brand_promotion_message"
in order to get it working with planning...

inheriting the web.brand_promotion_message and xpathing the fields seems to be the better choice.
As this would loose the character of a website module... What do you think?

[astirpe]

@NICO-SOLUTIONS

inheriting the web.brand_promotion_message and xpathing the fields seems to be the better choice. As this would loose the character of a website module... What do you think?

Yes, you are right: inheriting the web.brand_promotion_message would solve the conflicts.
I made a quick try locally with this xpath:

        <xpath expr="//t[@t-out]" position="replace">
            <t t-out=""/>
        </xpath>

but there are still some dirty characters left. So it seems not enough.

[astirpe]

Tested and works fine. Just don't know if the t-set needs to be replaced or not but it doesn't matter for the result.

[NICO-SOLUTIONS]

Tested and works fine. Just don't know if the t-set needs to be replaced or not but it doesn't matter for the result.

I added this because I had some leftovers when this is not set. But I'll cross check later on

[sanderlienaerts]

Status for getting this one merged?

[pedrobaeza]

@sanderlienaerts you can collaborate reviewing the PR: https://odoo-community.org/page/review

But in this case, the existing reviewers are reputed ones,so merging:

/ocabot merge nobump

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1017-by-pedrobaeza-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at a698130. Thanks a lot for contributing to OCA. ❤️

[NICO-SOLUTIONS]

thanks! @pedrobaeza