Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[9.0][website_snippet_country_dropdown] Migrate. #230

Merged
merged 12 commits into from
Sep 12, 2016
Merged

[9.0][website_snippet_country_dropdown] Migrate. #230

merged 12 commits into from
Sep 12, 2016

Conversation

yajo
Copy link
Member

@yajo yajo commented Jul 15, 2016 •
edited
Loading

Module migrated to v9.

😨 Snippets framework have changed a lot in v9!

@Tecnativa

sergio-teruel and others added 10 commits July 15, 2016 10:15
@sergio-teruel @yajo
[NEW][8.0] website_snippet_country_dropdown: New base module for coun…
fab7579 
…try dropdown flags.
@yajo
Add demo page.
3022fc9
@yajo
CSS to Sass. Include compiled version and CSS map.
b633902
@yajo
Fix typo.
6b53e6a
@yajo
Refactor snippet code.
21107a3 
- The `js_country_dropdown` class is added automatically by the template.
- Add `extra_class` variable to highest div element. You can set it to `has-error` for example.
- Add `default_value` variable to autopopulate the inputs.
- `default_country` is smarter now.
@yajo
Translate to Spanish.
5163e67
@yajo
[8.0][IMP][website_snippet_country_dropdown] Choose user's country by…
88c34ba 
… default.

With this patch, when the currently logged-in user has a country in its profile, it will be chosen by default for the flag.
@oca-transbot @yajo
OCA Transbot updated translations from Transifex
29ead2b
@yajo
[9.0][website_snippet_country_dropdown] Migrate.
a78129f
@yajo
Some minor improvements: fix a string, add placeholder support, docum…
bb368ae 
…ent variables.
@yajo yajo force-pushed the 9.0-website_snippet_country_dropdown-migration branch from 273ef84 to bb368ae Compare July 15, 2016 15:54
@rafaelbn rafaelbn added this to the 9.0 milestone Jul 15, 2016
@rafaelbn
Copy link
Member

Tested, please open runbot and check what happens with website, it says "could not execute commnad 'sass'

@yajo
Copy link
Member Author

yajo commented Jul 18, 2016

Most probably because Sass is not installed in runbot. @pedrobaeza Can you help here please?

@rafaelbn
Copy link
Member

Go to runbot -> Open - Error: "could not execute commnad 'sass'
cc @pedrobaeza

pedrobaeza
pedrobaeza reviewed Jul 27, 2016
View reviewed changes
website_snippet_country_dropdown/README.rst
* ``no_country_placeholder``.

You can view an example in
https://github.com/OCA/e-commerce/tree/8.0/website_sale_checkout_country_vat.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change this to a relative reference (only mention website_sale_checkout_country_vat in OCA/e-commerce)

@pedrobaeza
Copy link
Member

Sorry, I can't install binary files on runbot servers. Only Python libraries. You should contact @gurneyalex for that task.

@gurneyalex
Copy link
Member

@yajo @rafaelbn @pedrobaeza I just installed ruby-sass on runbot (and forced a rebuild of the PR).

@pedrobaeza
Copy link
Member

@gurneyalex, it seems that there's still missing a binary called bootstrap-sass.

@antespi
Copy link
Contributor

antespi commented Jul 30, 2016

@gurneyalex This is what we do to have all sass dependencies installed:

apt install -y ruby ruby2.3 ruby2.3-dev
gem install bootstrap-sass compass sass

@gurneyalex
Copy link
Member

@antespi @yajo I just installed these using gems, and triggered a rebuild. I'm not sure the required PATH update has been propagated up to the Odoo servers of the runbots, though. Please ping me if you see errors on the new build.

@yajo
Copy link
Member Author

yajo commented Aug 1, 2016

It seems to work.

@gurneyalex
Copy link
Member

👍

@rafaelbn
Copy link
Member

rafaelbn commented Aug 1, 2016

Hi @yajo , I tried to add snippet but is in red all the time. Could you try to check it please. See screenshots:

2016-08-01_21-23-16

@yajo
Copy link
Member Author

yajo commented Aug 5, 2016

Please keep in mind that you can never drag a field to a controller-dependant form. If the controller is not ready to accept such field, it could either do not do what you expect it to do, or simply blow up.

Because of that, Odoo seems to even forbid dragging the snippet into a <form> element that is inside an editable area (such as the one in the demo page). Not sure why, but anyway since the main purpose of this module is to provide a basis for other modules to use it in controller-enabled forms, and that has to be done from a module, I think I will just add that to known issues.

@rafaelbn
Copy link
Member

👍

@rafaelbn rafaelbn merged commit 9f29a4c into OCA:9.0 Sep 12, 2016
@pedrobaeza pedrobaeza deleted the 9.0-website_snippet_country_dropdown-migration branch September 12, 2016 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
7 participants
@yajo @rafaelbn @pedrobaeza @gurneyalex @antespi @sergio-teruel @oca-transbot