Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][16.0] stock_picking_completion_info #510

Merged

Conversation

glitchov
Copy link
Contributor

@glitchov glitchov commented Dec 2, 2022

Migration from 14.0

@glitchov glitchov force-pushed the 16.0-mig-stock_picking_completion_info-hda branch from 3f34b2b to a5a8bb2 Compare December 2, 2022 10:45
@@ -0,0 +1,2 @@
# https://github.com/OCA/stock-logistics-warehouse/pull/1566
odoo-addon-stock-move-common-dest @ git+https://github.com/acsone/[email protected]_move_common_dest-hda#subdirectory=setup/stock_move_common_dest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glitchov Please put this in a separate commit to easy removal.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add the depending PR on this PR description in order to easy reviewers job ? Thanks

@rousseldenis
Copy link
Contributor

/ocabot migration stock_picking_completion_info

Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. LGTM

@lmignon lmignon force-pushed the 16.0-mig-stock_picking_completion_info-hda branch from a5a8bb2 to 0087291 Compare December 5, 2022 14:54
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code reveiw)

Thank you @glitchov

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-510-by-rousseldenis-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 9, 2023
Signed-off-by rousseldenis
@OCA-git-bot
Copy link
Contributor

@rousseldenis your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-510-by-rousseldenis-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@rousseldenis
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-510-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3f0508a into OCA:16.0 Feb 9, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c235475. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-mig-stock_picking_completion_info-hda branch February 13, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants