Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] - shopfloor_mobile_base #694

Merged
merged 223 commits into from
May 2, 2024

Conversation

sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Jul 28, 2023

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 26, 2023
@sbejaoui sbejaoui force-pushed the 16.0-shopfloor_mobile_base-sbj branch from 4c5ce52 to ecde01f Compare December 25, 2023 17:16
@jbaudoux
Copy link
Contributor

@sbejaoui Can you drop from your migration commit the reformat of the external libs in shopfloor_mobile_base/static/wms/src/ ?
Can you put the exclude of this you added in precommit in a separate commit before the migration commit?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 31, 2023
@rousseldenis
Copy link
Contributor

/ocabot migration shopfloor_mobile_base

simahawk and others added 17 commits May 2, 2024 13:33
You can now decide if the action goes to the left or the right of the title.
When clicking on other elements (eg: btn) re-gain focus
after an update.
When you click on other elements on the page
the focus is normally obtainable via the  binding.
However, when  triggers a screen reload after an api call
that is not enough.
Before this change all the default headers (lang, version, uid)
were not passing when 'headers' were declared in 'odoo_params'.
Basically all the calls from sf_mobile's scenario were missing them.
The fake menu id is now mandatory.
This addresses 2 issues:

1. was not possible to register demo cases for the same scenario from different modules
2. there were 2 ways for registering cases and menu items were not so clear in the end
@lmignon lmignon force-pushed the 16.0-shopfloor_mobile_base-sbj branch from ecde01f to 78b1cb1 Compare May 2, 2024 11:34
@lmignon
Copy link
Contributor

lmignon commented May 2, 2024

@rousseldenis @jbaudoux Works in production for months. Can we merge-it?

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-694-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7e07675 into OCA:16.0 May 2, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fee84d2. Thanks a lot for contributing to OCA. ❤️

@lmignon lmignon deleted the 16.0-shopfloor_mobile_base-sbj branch May 3, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.