Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDXDSYS-1054 Investigate and fix how HAPI Pipelines appears in MixPanel #174

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Sep 23, 2024

I've added variable HDX_SITE and secrets for PREPREFIX and USER_AGENT to this repo. You need to add into your .useragents.yaml file in the usual format

Copy link

github-actions bot commented Sep 23, 2024

Test Results

17 tests  +17   17 ✅ +17   15m 10s ⏱️ + 15m 10s
 1 suites + 1    0 💤 ± 0 
 1 files   + 1    0 ❌ ± 0 

Results for commit cd4e772. ± Comparison against base commit 68f11ef.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 11001839864

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.6%

Totals Coverage Status
Change from base Build 10997051398: 0.2%
Covered Lines: 1594
Relevant Lines: 1703

💛 - Coveralls

Copy link
Member

@turnerm turnerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link
Collaborator

@b-j-mills b-j-mills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

mcarans and others added 3 commits September 24, 2024 08:17
* HDXDSYS-1043 add returnees

* HDXDSYS-1043 small typo fix

---------

Co-authored-by: Monica Turner <[email protected]>
@mcarans mcarans merged commit 05f5160 into main Sep 23, 2024
3 checks passed
mcarans added a commit that referenced this pull request Sep 23, 2024
* HDXDSYS-1043 add returnees

* HDXDSYS-1043 small typo fix

* HDXDSYS-1054 Investigate and fix how HAPI Pipelines appears in MixPanel (#174)

* Fix how HAPI Pipelines appears in MixPanel

* Fix variable

---------

Co-authored-by: Monica Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants