Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDXDSYS-1086 Add HNO freeform column to hapi-pipelines #183

Merged
merged 8 commits into from
Oct 15, 2024

Conversation

mcarans
Copy link
Contributor

@mcarans mcarans commented Oct 10, 2024

Also includes populating provider_admin1_name and provider_admin2_name

Note that I've used a cut down test file with MLI, SDN and UKR because the full file is too big to be used for a test

Copy link

github-actions bot commented Oct 10, 2024

Test Results

17 tests  ±0   17 ✅ ±0   18m 54s ⏱️ -48s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit b8f856d. ± Comparison against base commit c2c8db6.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Oct 10, 2024

Pull Request Test Coverage Report for Build 11355758553

Details

  • 45 of 51 (88.24%) changed or added relevant lines in 3 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 92.398%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/hapi/pipelines/database/admins.py 7 8 87.5%
src/hapi/pipelines/database/humanitarian_needs.py 34 39 87.18%
Files with Coverage Reduction New Missed Lines %
src/hapi/pipelines/database/humanitarian_needs.py 3 93.04%
Totals Coverage Status
Change from base Build 11337753111: -0.4%
Covered Lines: 1653
Relevant Lines: 1789

💛 - Coveralls

src/hapi/pipelines/database/humanitarian_needs.py Outdated Show resolved Hide resolved
tests/test_main.py Show resolved Hide resolved
@mcarans mcarans merged commit efc4c3b into main Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants