-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/global filtering #187
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 11374655042Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me and yes it would make sense to change admin_fuzzy_dont. I would make it so that it is based on parent|Central using similar logic to what's in get_admin_name_replacements in AdminLevel.
Once we release the changes I made in hdx-python-country this will be ready to release! |
I changed the filter on food security to include all countries, and added a country filter to the funding data. I checked the IPC p-code mappings and they're pretty good. I had to add a couple extra matching rules to get some countries to match.
There are just a few mismatched units in GHA that I either want to match to admin 1 or add to the admin_fuzzy_dont list. @mcarans I think we should change admin_fuzzy_don't to include iso codes so we don't eliminate fuzzy matching globally for common words like "Central". Or we could make the mappings a little more flexible to allow us to match to XXX units. Which do you think makes more sense?