-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDXDSYS-753 switch * with all and fix tests #49
Conversation
turnerm
commented
May 24, 2024
- switched any "*" to "all"
- added function to populate enums with values rather than keys
- fixed the tests: I added the suffix "constraint" to all constraint names, which would otherwise often be identical to column names. This prevents constraint tests passing if any error is thrown, since I think typically the error log contains all column names.
Pull Request Test Coverage Report for Build 9256563935Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the changes look good. I pushed an updated changelog.md to document them.