Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDXDSYS-753 switch * with all and fix tests #49

Merged
merged 4 commits into from
May 27, 2024
Merged

Conversation

turnerm
Copy link
Member

@turnerm turnerm commented May 24, 2024

  • switched any "*" to "all"
  • added function to populate enums with values rather than keys
  • fixed the tests: I added the suffix "constraint" to all constraint names, which would otherwise often be identical to column names. This prevents constraint tests passing if any error is thrown, since I think typically the error log contains all column names.

Copy link

github-actions bot commented May 24, 2024

Test Results

93 tests  ±0   93 ✅ ±0   16s ⏱️ -1s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 68bc841. ± Comparison against base commit e97cd81.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented May 24, 2024

Pull Request Test Coverage Report for Build 9256563935

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 31 of 31 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 80.739%

Totals Coverage Status
Change from base Build 9246547815: 0.1%
Covered Lines: 918
Relevant Lines: 1137

💛 - Coveralls

Copy link
Member

@davidmegginson davidmegginson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the changes look good. I pushed an updated changelog.md to document them.

@turnerm turnerm merged commit 94facf6 into main May 27, 2024
2 checks passed
@turnerm turnerm deleted the HDXDSYS-753-roll-ups branch May 27, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants