Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR HDX-9859 adapting patch table and VAT tables #51

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

alexandru-m-g
Copy link
Member

@alexandru-m-g alexandru-m-g commented Jun 5, 2024

There are no changes to the actual hapi schema here.
There are changes to the VAT tables (needed by the HAPI Write App) and to the Patch table + related tests:

  • adapting primary keys
  • some columns needed to be nullable
  • using enums

Copy link

github-actions bot commented Jun 5, 2024

Test Results

93 tests  ±0   93 ✅ ±0   16s ⏱️ ±0s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 52b022a. ± Comparison against base commit 9b183c8.

@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9383429399

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 80.756%

Totals Coverage Status
Change from base Build 9286286116: 0.02%
Covered Lines: 919
Relevant Lines: 1138

💛 - Coveralls

Copy link
Contributor

@IanHopkinson IanHopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I guess it covers off all those bits and pieces we couldn't do automatically.

@turnerm turnerm merged commit 35759ed into main Jun 5, 2024
2 checks passed
@turnerm turnerm deleted the feature/HDX-9859-write-app-changes branch June 5, 2024 13:29
@coveralls
Copy link

coveralls commented Jun 5, 2024

Pull Request Test Coverage Report for Build 9385042445

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 21 of 21 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 80.756%

Totals Coverage Status
Change from base Build 9286286116: 0.02%
Covered Lines: 919
Relevant Lines: 1138

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants