Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDXDSYS-843 add params and PKs to IDP #64

Merged
merged 5 commits into from
Sep 19, 2024
Merged

Conversation

turnerm
Copy link
Member

@turnerm turnerm commented Sep 17, 2024

Upon adding the DTM IDP data to HAPI, I was getting a duplicate key error if I did not include the operation name and round number in the primary key

Copy link

github-actions bot commented Sep 17, 2024

Test Results

117 tests  ±0   117 ✅ ±0   38s ⏱️ +11s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 4b0081c. ± Comparison against base commit 744423d.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 10940362705

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 83.546%

Totals Coverage Status
Change from base Build 10690217837: 0.03%
Covered Lines: 1112
Relevant Lines: 1331

💛 - Coveralls

Copy link
Member

@davidmegginson davidmegginson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks great. Thanks! I'll update Document 06 with the schema changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change makes sense -- thanks! I guess my mental model was that we'd include only the latest round, but it makes sense to design the PK to allow multiple rounds.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! I'd missed that there can be multiple operations per country, so this wasn't in the schema design in document 06, but it makes sense now that you've discovered it. I'll update the design docs to include this.

@turnerm turnerm merged commit 5a92a14 into main Sep 19, 2024
3 checks passed
@turnerm turnerm deleted the HDXDSYS-843-add-dtm-bugfix branch September 19, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants