-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDXDSYS-843 add params and PKs to IDP #64
Conversation
Pull Request Test Coverage Report for Build 10940362705Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks great. Thanks! I'll update Document 06 with the schema changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this change makes sense -- thanks! I guess my mental model was that we'd include only the latest round, but it makes sense to design the PK to allow multiple rounds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this! I'd missed that there can be multiple operations per country, so this wasn't in the schema design in document 06, but it makes sense now that you've discovered it. I'll update the design docs to include this.
Upon adding the DTM IDP data to HAPI, I was getting a duplicate key error if I did not include the operation name and round number in the primary key