-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR HDX-9844 national risk endpoint #101
PR HDX-9844 national risk endpoint #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. I can see the relevant tests are passing. My comments are all observations as I read rather than being actionable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we see location here because this dataset does not use admin1 and admin2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to make sure the generated views for hdx-class use the enums we see here (RiskClass)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering whether we should remove the un-versioned roots - they don't represent compatibility with the legacy version. The only reason to keep them is for a route to the "latest" version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must admit I don't like this pattern of having a "srv" function which does nothing but call the "view_list" function with all its arguments. I guess it gives us a place to change / modify arguments between user and query logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a bit of tidying up
…DX-9844-national-risk
53c6766
into
feature/HDX-9818-prepare-for-new-schema
national risk endpoint