Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR HDX-9844 national risk endpoint #101

Conversation

alexandru-m-g
Copy link
Member

national risk endpoint

Copy link
Collaborator

@IanHopkinson IanHopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. I can see the relevant tests are passing. My comments are all observations as I read rather than being actionable

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we see location here because this dataset does not use admin1 and admin2

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to make sure the generated views for hdx-class use the enums we see here (RiskClass)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering whether we should remove the un-versioned roots - they don't represent compatibility with the legacy version. The only reason to keep them is for a route to the "latest" version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must admit I don't like this pattern of having a "srv" function which does nothing but call the "view_list" function with all its arguments. I guess it gives us a place to change / modify arguments between user and query logic.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a bit of tidying up

@danmihaila danmihaila merged commit 53c6766 into feature/HDX-9818-prepare-for-new-schema May 22, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants