Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDX-9848 currency endpoint #115

Merged
merged 2 commits into from
May 24, 2024
Merged

HDX-9848 currency endpoint #115

merged 2 commits into from
May 24, 2024

Conversation

danmihaila
Copy link
Contributor

No description provided.

IanHopkinson
IanHopkinson approved these changes May 24, 2024
View reviewed changes
Copy link
Collaborator

@IanHopkinson IanHopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine - I just had a couple of queries over names.

hdx_hapi/endpoints/get_currency_response.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be get_currency.py for consistency with other endpoints

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spreadsheet asks for only code as a query parameter but I wonder whether this should be queryable by name too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i had the same question, but i just did it as it was in spreadsheet. we can review next week. ok with renaming

hdx_hapi/endpoints/models/currency_response.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly this one should be currency.py for consistency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

tests/test_endpoints/endpoint_data.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you attempting to check for case invariance here or is "usD" a typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

initially I did it with sensitive, but i checked other endpoints and switch to insensitive. we can easy change if DS team give us feedback

@danmihaila danmihaila merged commit f8793e5 into dev May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanHopkinson IanHopkinson IanHopkinson approved these changes

@alexandru-m-g alexandru-m-g alexandru-m-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danmihaila @IanHopkinson @alexandru-m-g