PR Feature/HDX-9848 wfp market endpoint #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandru-m-g
changed the title
danmihaila
approved these changes
May 24, 2024
IanHopkinson
approved these changes
May 24, 2024
There was a problem hiding this comment.
Nice to see I'm not the only one to make this mistake! (wfp-commodity, not wfp_commodity)
| db: AsyncSession, | ||
| code: Optional[str] = None, | ||
| name: Optional[str] = None, | ||
| # lat: Optional[float] = None, |
There was a problem hiding this comment.
I guess we are waiting for a decision before we implement a query for lat/lon
| async def test_get_wfp_market_params(event_loop, refresh_db): | ||
| log.info('started test_get_wfp_market_params') | ||
|
|
||
| for param_name, param_value in query_parameters.items(): |
There was a problem hiding this comment.
I found it useful for this test to log param_name, param_value before attempting the query - helpful when the test is failing, not so much when it passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.