HDX-9863 Make range queries for datasets with the "population" variable #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…min/max in endpoint_data.py
danmihaila
reviewed
May 30, 2024
| if population_min: | ||
| query = query.where(HumanitarianNeedsView.population >= population_min) | ||
| if population_max: | ||
| query = query.where(HumanitarianNeedsView.population <= population_max) |
There was a problem hiding this comment.
it looks good, but I noticed that for other filters we are using < ..max instead of <=max
There was a problem hiding this comment.
OK - I changed this to < in the three places it occurs.
danmihaila
approved these changes
May 30, 2024
alexandru-m-g
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds population_min and population_max quaery parameters to the population, humanitarian needs and refugees endpoints. Changes are in files like:
There are some minor, incidental changes in the documentation of the poverty-rate endpoint and also commenting out an instance of reference_period_start/end_min/max