Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDX-9881 Udpating ids in dataset and resource endpoints #133

Merged
merged 9 commits into from
Jun 4, 2024

Conversation

IanHopkinson
Copy link
Collaborator

@IanHopkinson IanHopkinson commented Jun 4, 2024

This PR renames query parameters and response parameters in the resource and dataset endpoints. This is done without requiring a change in hapi-sqlalchemy-schema.

The fields changed are as follows:
dataset:
hdx_id -> dataset_hdx_id
hdx_stub - > dataset_hdx_stub
title -> dataset_hdx_title
resource:
hdx_id -> resource_hdx_id
dataset_title -> dataset_hdx_title

Possible we should also change name in resource to resource_hdx_name.

The process, as described by @alexandru-m-g, is as follows:

  • change the Dataset pydantic model
  • change the DatasetView sqlAlchemy model
  • rename fields through the query path, starting with the endpoint router

Optional types added are not really part of this ticket. They were just missing.

@danmihaila danmihaila merged commit 71cd738 into dev Jun 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants