HDX-9960 Add has_hrp and in_gho to the query parameters and responses for all relevant endpoints #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new
has_hrpandin_ghoparameters to endpoints as query parameters and in responses. This is in response to this ticket.Many files are changes because each endpoint typically requires 5 or 6 files to be changed and only a couple of them are shared between endpoints.
The process for updating is included in
CONTRIBUTING.mdwith a view to making such updates easier in future. This represents a slightly special case because the new parameters are location related and are handled in some places by dedicated classes.The tests are all passing but the OpenAPI docs do not return data when doing sample queries because the new columns do not yet exist in the pipeline data.