Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo found by Ian in examples.md #187

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix typo found by Ian in examples.md #187

merged 1 commit into from
Aug 7, 2024

Conversation

cjhendrix
Copy link
Contributor

requeest to request

@IanHopkinson
Copy link
Collaborator

Tests are failing because GitHub Actions have depreciated docker-compose V1. What is our solution to this @teodorescuserban @alexandru-m-g? The solutions I see are:

  1. convert instances of "docker-compose" to "docker compose"
  2. Alias "docker compose" to "docker-compose"
  3. Install docker-compose V1

Of these I think (1) is best.

@alexandru-m-g
Copy link
Member

@IanHopkinson We went with option (1) on hdx related repos

@alexandru-m-g alexandru-m-g merged commit 20eca51 into dev Aug 7, 2024
1 of 2 checks passed
@alexandru-m-g alexandru-m-g deleted the cj-doc-edit branch August 7, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjhendrix @IanHopkinson @alexandru-m-g