Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to adapt the HDX HAPI app to cope with new datetime type annotations. Mainly this is replacing
sqlalchemy.NaiveDateTime
withdatetime.datetime
, and alsosqlalchemy.DateTime
. UsingNaiveDateTime
for response annotation rejects datetimes with time zone information and the new type annotation add time zones by default.Some endpoints used
NaiveDatetime
in their query parameter definitions, these were replaced and commented code was removed too. It is also found in theutil.py
file for definition of theReferencePeriodParameters
classThe majority of changes were in the response models where
NaiveDateTime
was used widely but not universally. Replacing these withdatetime.datetime
does not change OpenAPI documentation.