HDX-9819 Adapt the dataset and resource endpoints to the new schema #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dataset_resource_new_schema
danmihaila
approved these changes
May 16, 2024
| 'dataset_title': 'Dataset #1', | ||
| 'dataset_hdx_provider_stub': 'pRoViDeR01', | ||
| 'dataset_hdx_provider_stub': 'provider01', |
There was a problem hiding this comment.
I think this weird looking string, "pRoViDeR01", was there to tests case insensitivity
There was a problem hiding this comment.
I think I must have copied it over from elsewhere, I have no problem with the wierd casing.
| @@ -301,29 +303,30 @@ | |||
| 'admin2_name', | |||
| 'admin1_ref', | |||
| ], | |||
| }, | |||
| '/api/resource': { | |||
| }, # (hdx_id, dataset_hdx_id, name, format, update_date, is_hxl, download_url, hapi_updated_date) | |||
There was a problem hiding this comment.
is the commented line here on purpose ?
There was a problem hiding this comment.
I think it is a remnant of the process I used to make the file, so it can be deleted.
alexandru-m-g
approved these changes
May 16, 2024
IanHopkinson
merged commit 30440db
into
feature/HDX-9818-prepare-for-new-schema
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes updates to the new HAPI schema for the dataset and resource endpoints.
Note that the HAPI API uses title and dataset_title here, as specified in the spreadsheet which is inconsistent with usage elsewhere hdx_name is used (alongside hdx_stub)
I need to add a get_organizational_api_url function and add the related field to the API.