Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Feature/HDX-9830 3w and funding #96

Conversation

alexandru-m-g
Copy link
Member

Contains:

  • adapted 3w (operational presence)
  • new funding enpoint + logic
  • refactoring pydantic models with the set_admin1_admin2_null() function
  • other small refactorings

@alexandru-m-g alexandru-m-g force-pushed the feature/HDX-9830-3w-and-funding branch from f00508e to d6e52bc Compare May 19, 2024 11:53
Copy link
Collaborator

@IanHopkinson IanHopkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

I like the HapiModelWithAdmins refactoring - I was thinking about something like this myself (but didn't know how to do it)

I'm assuming you have done the visual check of the endpoints on the docs page.

I'm struggling to keep up with your refactorings in my population branch! I

@alexandru-m-g
Copy link
Member Author

@IanHopkinson , thanks for the review. I think you can avoid the refactorings in your branch (if you can avoid pulling the changes in) and I can deal with them when I merge your changes.

@danmihaila danmihaila merged commit 2c135eb into feature/HDX-9818-prepare-for-new-schema May 20, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants