Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make check fails with latest code because of missing ocrd-tesserocr-binarize #420

Closed
stweil opened this issue Mar 14, 2024 · 5 comments
Closed

Comments

@stweil
Copy link
Collaborator

stweil commented Mar 14, 2024

It looks like none of the ocrd-tesserocr-* executables is installed.

I noticed this first while implementing CI for macOS (see protocol), but could reproduce it with x86_64 as well (see protocol).

@stweil
Copy link
Collaborator Author

stweil commented Mar 14, 2024

@bertsky, maybe this is not an issue for ocr_all but for ocrd_tesserocr.

stweil added a commit that referenced this issue Mar 14, 2024
`make all` did not build ocrd_tesserocr if it was started without a
virtual Python environment because ocrd_tesserocr requires a venv
for building.

Signed-off-by: Stefan Weil <[email protected]>
@stweil
Copy link
Collaborator Author

stweil commented Mar 14, 2024

Release v2024-02-01 also fails during make check, but with a different error:

TypeError: 'ocrd_froc.processor' is not a package
make: *** [Makefile:762: /home/runner/work/ocrd_all/ocrd_all/venv/bin/ocrd-froc-recognize-check] Error 1

@stweil
Copy link
Collaborator Author

stweil commented Mar 14, 2024

@bertsky, maybe this is not an issue for ocr_all but for ocrd_tesserocr.

I have sent a fix in pull request #422.

@stweil
Copy link
Collaborator Author

stweil commented Mar 14, 2024

@bertsky, I still wonder why the CI continued after make all although that failed to build ocrd_tesserocr. It should have stopped instead of continuing with make check.

@stweil
Copy link
Collaborator Author

stweil commented Mar 15, 2024

Pull request #422 fixes this issue, see the CI protocol, but now make check fails because of ocrd_froc as with release v2024-02-01. That's a separate issue.

stweil added a commit that referenced this issue Mar 18, 2024
`make all` did not build ocrd_tesserocr if it was started without a
virtual Python environment because ocrd_tesserocr requires a venv
for building.

Signed-off-by: Stefan Weil <[email protected]>
@stweil stweil closed this as completed Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant