Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor recognize #25

Merged
merged 5 commits into from
Oct 26, 2018
Merged

Refactor recognize #25

merged 5 commits into from
Oct 26, 2018

Conversation

kba
Copy link
Member

@kba kba commented Oct 25, 2018

process has been too long and with too many nested loops and code duplication for the glyph-in-word. Not supposed to change any behavior.

@kba kba requested a review from noahmetzger October 25, 2018 13:39
@kba
Copy link
Member Author

kba commented Oct 25, 2018

@bertsky Pleae have a look to make sure I didn't break any of it. Thanks

bertsky
bertsky requested changes Oct 25, 2018
View reviewed changes
Copy link
Collaborator

@bertsky bertsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kba Thanks for addressing this and including me. I added one comment each from sifting through the changes. I will now attempt some practical tests.

ocrd_tesserocr/recognize.py Outdated Show resolved Hide resolved
ocrd_tesserocr/recognize.py Outdated Show resolved Hide resolved
@kba kba merged commit b6e1f59 into OCR-D:master Oct 26, 2018
@kba kba deleted the refactor-recognize branch October 26, 2018 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertsky bertsky bertsky approved these changes

@noahmetzger noahmetzger Awaiting requested review from noahmetzger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kba @bertsky