Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django2 #194

Merged
merged 38 commits into from
Jan 26, 2018
Merged

Django2 #194

merged 38 commits into from
Jan 26, 2018

Conversation

miguelcleon
Copy link
Member

@miguelcleon miguelcleon commented Jan 23, 2018

updates for compatability with django 2.0 and python 3.6. Also updates for exporting to hydroshare functionality.

@miguelcleon
Copy link
Member Author

@lsetiawan @ocefpaf I updated code for django 2.0.1 and python 3.6 travis is still failing though. Maybe something I did with the travis.yml is wrong?

@miguelcleon
Copy link
Member Author

miguelcleon commented Jan 23, 2018

hs_restclient isn't on a conda channel, maybe it can be added to conda-forge? This is a python REST client for hydroshare.org I'm using to export data. https://pypi.python.org/pypi/hs_restclient I added it as a pip install in travis.yml

@miguelcleon
Copy link
Member Author

oh I see django-fixture-magic is also not on a conda channel.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 24, 2018

@miguelcleon see conda-forge/staged-recipes#4839

Once that PR is merged those packages will be available on the conda-forge channel.

Miguel Leon added 4 commits January 24, 2018 10:08
changes for travis
update to requirements
requirements change for travis
update for travis
@miguelcleon
Copy link
Member Author

Great, thanks @ocefpaf it looks like travis got passed the enivronment build errors and is now encountering issues in the ODM2 Admin code I need to look at. One more django package will need to be added to conda-forge for this social-auth-app-django can that be added as well?

@ocefpaf
Copy link
Member

ocefpaf commented Jan 24, 2018

One more django package will need to be added to conda-forge for this social-auth-app-django can that be added as well?

Yep. See conda-forge/staged-recipes#4840

@miguelcleon
Copy link
Member Author

The error on travis is now OSError: /home/travis/miniconda/envs/TEST/lib/libgdal.so: cannot open shared object file: No such file or directory
Maybe need to install gdal in travis.yml? gdal has been a requirement for a long time so I'm not sure.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 24, 2018

Maybe need to install gdal in travis.yml?

Not really. It is something else. Let me check this later today and I'll get back to you.

Miguel Leon and others added 3 commits January 24, 2018 11:54
This is a settings file for instances of ODM2 Admin which are generated when uploading data to Hydroshare. To create a ODM2 SQLite file another instance of ODM2 Admin is needed.
Miguel Leon added 4 commits January 24, 2018 12:24
add a missing setting to settings  - EXPORTDB flag used - if set to true this will use Camel case table names for SQLite
blank ODM2 Admin db
…o export data to a SQLite file for upload to Hydroshare a new instance of ODM2 Admin is created. This is the settings file for those instances.
@miguelcleon
Copy link
Member Author

For the last update the error was psycopg2.OperationalError: FATAL: role "user" does not exist, I've added a blank ODM2 database which was missing. I'm not sure how travis sets up postgresql. @lsetiawan ? Maybe I need the travis.yml from the testing branch? I think I've been building off an older one.

@miguelcleon
Copy link
Member Author

it's failing on test execution.

@miguelcleon
Copy link
Member Author

changing setup.py didn't help I'm still getting psycopg2.OperationalError: FATAL: role "user" does not exist

@miguelcleon
Copy link
Member Author

The problem I think has to do with the test database django creates for testing.

@miguelcleon
Copy link
Member Author

I thought maybe I fixed it but now I'm getting the below error which seems odd. @ocefpaf any ideas about this?


$ if [[ $TEST_TARGET == 'default' ]]; then python $TRAVIS_BUILD_DIR/manage.py test tests/; python fi
/home/travis/.travis/job_stages: eval: line 58: syntax error: unexpected end of file
The command "if [[ $TEST_TARGET == 'default' ]]; then python $TRAVIS_BUILD_DIR/manage.py test tests/; python fi" exited with 1.

@miguelcleon
Copy link
Member Author

I think I see it.

@miguelcleon
Copy link
Member Author

Yes!! it worked thanks much @ocefpaf and @lsetiawan ! 🍾 🎆

@miguelcleon miguelcleon merged commit 1c4a050 into master Jan 26, 2018
miguelcleon pushed a commit that referenced this pull request Jan 30, 2018
Merge pull request #194 from ODM2/django2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants