Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Core Vocabulary to include IsDelta #3087

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update Core Vocabulary to include IsDelta #3087

merged 1 commit into from
Oct 15, 2024

Conversation

mikepizzo
Copy link
Member

Issues

This pull request fixes #3086.

Description

Updated the OASIS Core vocabulary to include the IsDelta term.
Updated the tests to validate this term.

Checklist (Uncheck if it is not completed)

  • Test cases added
  • Build and test with one-click build and test script passed

Additional work necessary

None

@@ -566,6 +572,7 @@ public void TestCoreVocabularyEnumType(string typeName, string members, bool isF
[InlineData("SchemaVersion", "Edm.String", "Schema Reference")]
[InlineData("ODataVersions", "Edm.String", "EntityContainer")]
[InlineData("Example", "Org.OData.Core.V1.ExampleValue", "EntityType ComplexType TypeDefinition Term Property NavigationProperty Parameter ReturnType")]
[InlineData("IsDelta","Org.OData.Core.V1.Tag","ReturnType Parameter")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new line looks unnecessary.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing that the IsDelta term is defined in the vocabulary. Of course, that should also be apparent from comparing the expected text, but that's how the test is designed.

@mikepizzo mikepizzo merged commit 2a568db into main Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Core vocabulary to include IsDelta
2 participants