Use CMAKE_INSTALL_FULL_* for absolute paths #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using a combination of CMAKE_INSTALL_PREFIX and CMAKE_INSTALL_<dirname>, we should use CMAKE_INSTALL_FULL_<dirname>. If the CMAKE_INSTALL_<dirname> is an absolute path (e.g. in NixOS), then prefixing it with another absolute path would be incorrect. CMAKE_INSTALL_FULL_<dirname> already handles the case if CMAKE_INSTALL_<dirname> is an absolute path. See: https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html Signed-off-by: Daniel Fullmer <[email protected]>
ichergui
approved these changes
Mar 11, 2022
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using a combination of CMAKE_INSTALL_PREFIX and
CMAKE_INSTALL_, we should use CMAKE_INSTALL_FULL_.
If the CMAKE_INSTALL_ is an absolute path (e.g. in NixOS), then
prefixing it with another absolute path would be incorrect.
CMAKE_INSTALL_FULL_ already handles the case if
CMAKE_INSTALL_ is an absolute path. See:
https://cmake.org/cmake/help/latest/module/GNUInstallDirs.html
Signed-off-by: Daniel Fullmer [email protected]