[GL3+] add support for currentGLContext for macOS #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support the parameter 'currentGLContext' on macOS for the GL3+ RS - Initialise pointers to nil in CocoaWindow::create - Add checks to ensure that attempts to create new Cocoa windows or set a view on an OpenGL context only occur on the main thread Signed-off-by: Rhys Mainwaring <[email protected]>
This was referenced Aug 2, 2021
|
Hi! Thanks for the PR! I've fixed all build errors I could see when using the XCode generator on the v2-2 branch (except for MorphAnimations sample. Just comment that sample from CMakeLists) I haven't merged those changes into master yet, but if you're in a rush hopefully master should merge with no conflicts with v2-2 Edit: Merging bb2aae5 into master should be fine, but latest commits will cause lots of conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the parameter 'currentGLContext' on macOS for the GL3+ RS
There are also a couple of minor changes to help with debugging and multi-threaded applications:
I've applied the PR to v2-1 as there are difficulties compiling master on macOS at present. Ideally this change would be present on master and backported to v2-1 and v2-2. It is a pre-requisite for macOS support in the downstream project ignition-gui and ignition-gazebo.