fix(segmentation scroll): and hydration bugs (#3701)

OHIF · Oct 6, 2023 · 1fd98d9 · 1fd98d9
1 parent 748acaf
commit 1fd98d9
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 21 deletions.
diff --git a/extensions/cornerstone-dicom-seg/src/panels/PanelSegmentation.tsx b/extensions/cornerstone-dicom-seg/src/panels/PanelSegmentation.tsx
@@ -217,7 +217,7 @@ export default function PanelSegmentation({
 
   return (
     <>
-      <div className="flex min-h-0 flex-auto select-none flex-col justify-between">
+      <div className="ohif-scrollbar flex min-h-0 flex-auto select-none flex-col justify-between overflow-auto">
         <SegmentationGroupTable
           title={t('Segmentations')}
           segmentations={segmentations}

diff --git a/platform/ui/src/components/Notification/Notification.tsx b/platform/ui/src/components/Notification/Notification.tsx
@@ -18,10 +18,14 @@ const Notification = ({ id, type, message, actions, onSubmit, onOutsideClick })
       }
     };
 
+    // Both a mouse down and up listeners are desired so as to avoid missing events
+    // from elements that have pointer-events:none (e.g. the active viewport).
     document.addEventListener('mousedown', handleClick);
+    document.addEventListener('mouseup', handleClick);
 
     return () => {
       document.removeEventListener('mousedown', handleClick);
+      document.removeEventListener('mouseup', handleClick);
     };
   }, [onOutsideClick]);
 

diff --git a/platform/ui/src/components/SegmentationGroupTable/SegmentationDropDownRow.tsx b/platform/ui/src/components/SegmentationGroupTable/SegmentationDropDownRow.tsx
@@ -75,14 +75,16 @@ function SegmentationDropDownRow({
                       storeSegmentation(activeSegmentation.id);
                     },
                   },
-                  {
-                    title: 'Download',
-                    onClick: () => {
-                      onSegmentationDownload(activeSegmentation.id);
-                    },
-                  },
                 ]
               : []),
+            ...[
+              {
+                title: 'Download',
+                onClick: () => {
+                  onSegmentationDownload(activeSegmentation.id);
+                },
+              },
+            ],
           ]}
         >
           <div className="hover:bg-secondary-dark mx-1 grid h-[28px] w-[28px]  cursor-pointer place-items-center rounded-[4px]">

diff --git a/platform/ui/src/components/SegmentationGroupTable/SegmentationGroupTable.tsx b/platform/ui/src/components/SegmentationGroupTable/SegmentationGroupTable.tsx
@@ -104,20 +104,18 @@ const SegmentationGroupTable = ({
             </div>
           ) : (
             <div className="mt-1 select-none">
-              {!disableEditing && (
-                <SegmentationDropDownRow
-                  segmentations={segmentations}
-                  disableEditing={disableEditing}
-                  activeSegmentation={activeSegmentation}
-                  onActiveSegmentationChange={onActiveSegmentationChange}
-                  onSegmentationDelete={onSegmentationDelete}
-                  onSegmentationEdit={onSegmentationEdit}
-                  onSegmentationDownload={onSegmentationDownload}
-                  storeSegmentation={storeSegmentation}
-                  onSegmentationAdd={onSegmentationAdd}
-                  onToggleSegmentationVisibility={onToggleSegmentationVisibility}
-                />
-              )}
+              <SegmentationDropDownRow
+                segmentations={segmentations}
+                disableEditing={disableEditing}
+                activeSegmentation={activeSegmentation}
+                onActiveSegmentationChange={onActiveSegmentationChange}
+                onSegmentationDelete={onSegmentationDelete}
+                onSegmentationEdit={onSegmentationEdit}
+                onSegmentationDownload={onSegmentationDownload}
+                storeSegmentation={storeSegmentation}
+                onSegmentationAdd={onSegmentationAdd}
+                onToggleSegmentationVisibility={onToggleSegmentationVisibility}
+              />
               {!disableEditing && showAddSegment && (
                 <AddSegmentRow onClick={() => onSegmentAdd(activeSegmentationId)} />
               )}