Skip to content

Commit

Permalink
fix(memory leak): array buffer was sticking around in volume viewports (
Browse files Browse the repository at this point in the history
  • Loading branch information
sedghi authored Aug 23, 2023
1 parent fe0ee05 commit 65b49ae
Show file tree
Hide file tree
Showing 8 changed files with 38 additions and 36 deletions.
6 changes: 3 additions & 3 deletions extensions/cornerstone-dicom-sr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@
},
"dependencies": {
"@babel/runtime": "^7.20.13",
"@cornerstonejs/adapters": "^1.10.3",
"@cornerstonejs/core": "^1.10.3",
"@cornerstonejs/tools": "^1.10.3",
"@cornerstonejs/adapters": "^1.11.1",
"@cornerstonejs/core": "^1.11.1",
"@cornerstonejs/tools": "^1.11.1",
"classnames": "^2.3.2"
}
}
10 changes: 5 additions & 5 deletions extensions/cornerstone/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@cornerstonejs/codec-libjpeg-turbo-8bit": "^1.2.2",
"@cornerstonejs/codec-openjpeg": "^1.2.2",
"@cornerstonejs/codec-openjph": "^2.4.2",
"@cornerstonejs/dicom-image-loader": "^1.10.3",
"@cornerstonejs/dicom-image-loader": "^1.11.1",
"@ohif/core": "3.7.0-beta.56",
"@ohif/ui": "3.7.0-beta.56",
"dcmjs": "^0.29.6",
Expand All @@ -52,10 +52,10 @@
},
"dependencies": {
"@babel/runtime": "^7.20.13",
"@cornerstonejs/adapters": "^1.10.3",
"@cornerstonejs/core": "^1.10.3",
"@cornerstonejs/streaming-image-volume-loader": "^1.10.3",
"@cornerstonejs/tools": "^1.10.3",
"@cornerstonejs/adapters": "^1.11.1",
"@cornerstonejs/core": "^1.11.1",
"@cornerstonejs/streaming-image-volume-loader": "^1.11.1",
"@cornerstonejs/tools": "^1.11.1",
"@kitware/vtk.js": "27.3.1",
"html2canvas": "^1.4.1",
"lodash.debounce": "4.0.8",
Expand Down
1 change: 0 additions & 1 deletion extensions/cornerstone/src/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ const cornerstoneExtension: Types.Extensions.Extension = {
imageRetrievalPoolManager.clearRequestStack(type);
});

csWADOImageLoader.destroy();
enabledElementReset();
},

Expand Down
4 changes: 2 additions & 2 deletions extensions/measurement-tracking/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
"start": "yarn run dev"
},
"peerDependencies": {
"@cornerstonejs/core": "^1.10.3",
"@cornerstonejs/tools": "^1.10.3",
"@cornerstonejs/core": "^1.11.1",
"@cornerstonejs/tools": "^1.11.1",
"@ohif/core": "3.7.0-beta.56",
"@ohif/extension-cornerstone-dicom-sr": "3.7.0-beta.56",
"@ohif/ui": "3.7.0-beta.56",
Expand Down
2 changes: 1 addition & 1 deletion platform/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@cornerstonejs/codec-libjpeg-turbo-8bit": "^1.2.2",
"@cornerstonejs/codec-openjpeg": "^1.2.2",
"@cornerstonejs/codec-openjph": "^2.4.2",
"@cornerstonejs/dicom-image-loader": "^1.10.3",
"@cornerstonejs/dicom-image-loader": "^1.11.1",
"@ohif/core": "3.7.0-beta.56",
"@ohif/extension-cornerstone": "3.7.0-beta.56",
"@ohif/extension-cornerstone-dicom-rt": "3.7.0-beta.56",
Expand Down
2 changes: 1 addition & 1 deletion platform/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@cornerstonejs/codec-libjpeg-turbo-8bit": "^1.2.2",
"@cornerstonejs/codec-openjpeg": "^1.2.2",
"@cornerstonejs/codec-openjph": "^2.4.2",
"@cornerstonejs/dicom-image-loader": "^1.10.3",
"@cornerstonejs/dicom-image-loader": "^1.11.1",
"@ohif/ui": "3.7.0-beta.56",
"cornerstone-math": "0.1.9",
"dicom-parser": "^1.8.21"
Expand Down
3 changes: 3 additions & 0 deletions publish-version.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,9 @@ async function run() {
'--force-publish',
'--message',
'chore(version): Update package versions [skip ci]',
'--conventional-commits',
'--create-release',
'github',
]);

console.log('Version set using lerna');
Expand Down
46 changes: 23 additions & 23 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1376,10 +1376,10 @@
resolved "https://registry.yarnpkg.com/@colors/colors/-/colors-1.5.0.tgz#bb504579c1cae923e6576a4f5da43d25f97bdbd9"
integrity sha512-ooWCrlZP11i8GImSjTHYHLkvFDP48nS4+204nGb1RiX/WXYHmJA2III9/e2DWVabCESdW7hBAEzHRqUn9OUVvQ==

"@cornerstonejs/adapters@^1.10.3":
version "1.10.3"
resolved "https://registry.yarnpkg.com/@cornerstonejs/adapters/-/adapters-1.10.3.tgz#20e8babb35028b04a4579646c565e8e4523ad4fe"
integrity sha512-cZO7V2hO8Al+KKhfCk5Y/+7zilFmz/Cv0I5PegsNS1YFfiMII9xCkLIKD/MO9ytAlBI6rDcB+lvkLvUM7gYUeg==
"@cornerstonejs/adapters@^1.11.1":
version "1.11.1"
resolved "https://registry.yarnpkg.com/@cornerstonejs/adapters/-/adapters-1.11.1.tgz#d6c2b0dc0742a0ffd76e9ed86f911bbd8bc94c05"
integrity sha512-ggSToAWv6fn7J4mq412P6xGV5IdbtHqRR4ZGap12ytus9HCCZLZ3a+lWx21+Rc9zILj8H/58WWb/pYvN0Itp5g==
dependencies:
"@babel/runtime-corejs2" "^7.17.8"
buffer "^6.0.3"
Expand Down Expand Up @@ -1428,43 +1428,43 @@
resolved "https://registry.yarnpkg.com/@cornerstonejs/codec-openjph/-/codec-openjph-2.4.2.tgz#e96721d56f6ec96f7f95c16321d88cc8467d8d81"
integrity sha512-lgdvBvvNezleY+4pIe2ceUsJzlZe/0PipdeubQ3vZZOz3xxtHHMR1XFCl4fgd8gosR8COHuD7h6q+MwgrwBsng==

"@cornerstonejs/core@^1.10.3":
version "1.10.3"
resolved "https://registry.yarnpkg.com/@cornerstonejs/core/-/core-1.10.3.tgz#3bf26136d1335f72fbf4a6b8ba4d953db9255a76"
integrity sha512-JPhY+ANSl3wWjGKbh9efVYwRRu7FvXbulKwAkwYfm5KO23sVoxkN6EIuWu+VgrfjQQN9lQoCUSLH39a6PulSug==
"@cornerstonejs/core@^1.11.1":
version "1.11.1"
resolved "https://registry.yarnpkg.com/@cornerstonejs/core/-/core-1.11.1.tgz#308904eabcd54bf8529ba174ff714a2aa7cd0be7"
integrity sha512-QgGVRiS2ceDSC0kZlYyYw6owqh6rn7FaYuyJAYis1JCk1yG6xIUfcb6GMuubuEgEammc26i8EfU1H5FLxpHm2g==
dependencies:
"@kitware/vtk.js" "27.3.1"
detect-gpu "^5.0.22"
gl-matrix "^3.4.3"
lodash.clonedeep "4.5.0"

"@cornerstonejs/dicom-image-loader@^1.10.3":
version "1.10.3"
resolved "https://registry.yarnpkg.com/@cornerstonejs/dicom-image-loader/-/dicom-image-loader-1.10.3.tgz#e8f9d9188c2ef8a1920b4b3a29864470adc5a307"
integrity sha512-ES2D2YRMX18ws9Udqbkj3rt5f2akt9UoL8N8hlrcAX59MBUGkrY5Feo/898Eav1Mx5mnwOZn0DMETeE3MSkwcQ==
"@cornerstonejs/dicom-image-loader@^1.11.1":
version "1.11.1"
resolved "https://registry.yarnpkg.com/@cornerstonejs/dicom-image-loader/-/dicom-image-loader-1.11.1.tgz#0a7786b97828038f6faca088b40cc2b96c7db362"
integrity sha512-5/ocRRoYiwKKcKR01oGwWQp3imPEEYJcHull7MuwMWS1mZgYvok0QGs5Wz51rY8qJZCuM7nvkKxI21YzQkxISw==
dependencies:
"@cornerstonejs/codec-charls" "^1.2.3"
"@cornerstonejs/codec-libjpeg-turbo-8bit" "^1.2.2"
"@cornerstonejs/codec-openjpeg" "^1.2.2"
"@cornerstonejs/codec-openjph" "^2.4.2"
"@cornerstonejs/core" "^1.10.3"
"@cornerstonejs/core" "^1.11.1"
dicom-parser "^1.8.9"
pako "^2.0.4"
uuid "^9.0.0"

"@cornerstonejs/streaming-image-volume-loader@^1.10.3":
version "1.10.3"
resolved "https://registry.yarnpkg.com/@cornerstonejs/streaming-image-volume-loader/-/streaming-image-volume-loader-1.10.3.tgz#44d5d0777b6a0aff26785d6fd695069476f797ce"
integrity sha512-cZB//zkWsjRwaUYo3GZrx96FsycF41031Hb4UdFkmXHUVCUE8SYpiVZg7VD3cjtEiGCeDSReHVAzSVavUXqUYg==
"@cornerstonejs/streaming-image-volume-loader@^1.11.1":
version "1.11.1"
resolved "https://registry.yarnpkg.com/@cornerstonejs/streaming-image-volume-loader/-/streaming-image-volume-loader-1.11.1.tgz#4f48b9af36da090f51e91b9736d892c4450244cd"
integrity sha512-S++wH3u037Gw5I51DWNwvqYaJl9W8vNhebTSzQIgZO3TVShzJo+0zQWdrsXrqOSzn9+0d4H6yEdxjKvsDRYBMw==
dependencies:
"@cornerstonejs/core" "^1.10.3"
"@cornerstonejs/core" "^1.11.1"

"@cornerstonejs/tools@^1.10.3":
version "1.10.3"
resolved "https://registry.yarnpkg.com/@cornerstonejs/tools/-/tools-1.10.3.tgz#d3ba9db77489560828baccd239ebea647cb8d220"
integrity sha512-Z8PzL26cvDQP8PUQpNk48oSbNqoQ64bWJT96hUd2xZ+X92shiDkiMoI4v20jylSaorw7uMUPCMAooFdHG5Dp0w==
"@cornerstonejs/tools@^1.11.1":
version "1.11.1"
resolved "https://registry.yarnpkg.com/@cornerstonejs/tools/-/tools-1.11.1.tgz#537caff00b53b7d37ea31d5aa67ec09298ce8057"
integrity sha512-kt6UTHT24PffiEDuHSTOiRTSfYHaluWTY27bigr0wdnrMYMlO0oignFXiSJAJ0FzLZUhuRZeN7qs1fLXhOlcrA==
dependencies:
"@cornerstonejs/core" "^1.10.3"
"@cornerstonejs/core" "^1.11.1"
lodash.clonedeep "4.5.0"
lodash.get "^4.4.2"

Expand Down

0 comments on commit 65b49ae

Please sign in to comment.