Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurement error (pixel resolution) for XA (ImagerPixelSpacing (0018,1164)) #201

Closed
rossetantoine opened this issue Jun 9, 2018 · 5 comments
Assignees

Comments

@rossetantoine
Copy link

The measurements produced by OHIF are wrong, if pixel resolution is stored in ImagerPixelSpacing fields).

See attached image and DICOM file: the diameter should be 3 mm, instead of 15 mm.

The DICOM file is also attached.

XA-DICOM.dcm.zip

ohif

@dannyrb
Copy link
Member

dannyrb commented May 23, 2019

I believe this has been resolved. If you're still seeing this issue in master, please don't hesitate to comment and I will be more than happy to re-open and investigate further.

@Zaid-Safadi
Copy link
Contributor

This is not resolved, the value is only displayed in pixels rather than "mm" (which is better) but we should be able to display a valid measurement "3 mm" as other viewers

Latest OHIF Master:
image

MicroDicom
image

@Zaid-Safadi Zaid-Safadi reopened this Nov 23, 2019
@dannyrb
Copy link
Member

dannyrb commented Nov 23, 2019

Read @chafey's comments here: cornerstonejs/cornerstoneWADOImageLoader#261 (comment)

We can't use imagerPixelSpacing as a fallback, or at least we shouldn't in these libraries. It introduces a hazard that should be a deliberate decision for anyone creating a viewer implementation.

That, at least, has been the guidance for all cornerstone libraries to date. Stick to the standard and try not to make allowances for vendors that don't adhere to them.


@swederik is the product owner. If you can convince him otherwise, we could introduce it as a fallback in OHIF libraries. We also have the ability to show a warning, highlight the hazard, or make this an opt-in behavior. The issue then becomes, if we persist these annotations, that warning likely wouldn't be recorded with what would be perceived as 100% accurate measurements.


@Zaid-Safadi, just now reading your response to @chafey. If the behavior is inconsistent with the standard, we can of course rectify things! I'll brush up on my understanding, and wait for this conversation to play out.

@Zaid-Safadi
Copy link
Contributor

I would recommend we keep this open for reference as this is something that OHIF as a viewer/display application needs to address.

Whether reading the imagerPixelSpacing value in cornerstone library or directly in OHIF is agnostic from the fact that there are cases where the user wants to display the measurements in "mm" if imagerPixelSpacing is the only attribute available which is the current behavior in the original post and the viewers I have seen so far.

@swederik
Copy link
Member

This was fixed (finally) by #1555

Screenshot 2020-03-25 at 23 58 34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants