-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OHIF error when opening studies #2138
Comments
Additional: Stack Trace: in ViewportOverlay |
Study failing (one from some others): https://drive.google.com/file/d/1GGzKjVCB7t3ItrzeR96SB7p_f1hb_esL/view?usp=sharing |
Same here |
same here |
Same issue here |
Facing same issue. Any solution for this ? ViewerMain: windowWidth.toFixed is not a function in ViewportOverlay (created by CornerstoneViewport) |
I have the same bug with dcm4chee-arc-psql:5.22.6-secure-ui. |
can you share your yml file? |
sorry I can't share the full yml file, but just add the version tags to your dcm4chee service in your yml like this:
|
@davidthemaster30 thanks! I tried but it didn't resolve my error! |
The error is not from OHIF Viewer, but the dependent library "react-cornerstone-viewport". You can change in the ./node_modules/react-cornerstone-viewport/dist/index.umd.js. |
This solution seems to work. Thanx @bianyueyan |
Hi @bianyueyan I'm using latest ohif viewer from docker in debian 10, can you help me?, i have been searching index.umd.js, but I can not find it :( Thanks |
you won't find index.umd.js in 'ohif/viewer:latest' on docker, because it's already compiled. You need change it before it's compiled, so you'll need to make you own Dockerfile. You can base your own on the one that's used for the official build https://github.com/OHIF/Viewers/blob/master/Dockerfile FYI,
is on line 7066 in "node_modules/react-cornerstone-viewport/dist/index.umd.js". the node_modules folder is only created when "yarn install" is executed. |
Just tested the fix, and it does get rid on the error. But images appear either solid white or solid black. |
I checked this issue in the releases @OHIF:[email protected]
By performing these changes in the latest version series of other errors appeared for me:
I could open different issues for each case. But I could not use ohif viewer's latest versions connected to dcm4chee 5. |
thanks @ken-proradis ohif/viewer:v2.11.8.7749 (the latest v2 version) works!. I also tried the v3 (ohif/viewer:v3.11.11.11515, the latest v3) and it has the same error as v4. |
This errors appear when the metadata is formed. On old dcm4chee arc WindowCenter and WindowWidth appear as number, float or integer in the metadata as is expected .
to And all worked as the past with CR and DR images. This workaround will not working with CT modalities. |
I changed
to in the "MetadataProvider.js" it is working for CT modalities. |
@bianyueyan thank you. I can go further based on your solution. I modified Metadata.js and add this lines, and removed all modifications on MetadataProvider. getData() { metadataSanitizer( data ){
} |
I wish update directly on github, but I cannot pull |
I experienced the same error after updating our dcm4chee-arc-psql from 5.22.4 to 5.23.2. After some investigation it seems to me that the DICOM JSON representation of the metadata returned by dcm4chee changed. In 5.22.4 DICOM tags where the VR is I am pretty new to this project so I am not sure if my suggestions are of any value, but for me it seems there are a few different solutions:
As a workaround I have implemented solution 1 which seems to work: --- node_modules/dcmjs/build/dcmjs.es.js.old 2021-04-01 16:13:39.755351407 +0200
+++ node_modules/dcmjs/build/dcmjs.es.js 2021-04-01 16:15:33.119409498 +0200
@@ -2778,6 +2778,8 @@
naturalValues.push(DicomMetaDictionary.naturalizeDataset(data.Value[index]));
});
naturalDataset[naturalName] = naturalValues;
+ } else if (data.vr === "DS") {
+ naturalDataset[naturalName] = data.Value.map(x => { return Number(x) });
} else {
naturalDataset[naturalName] = data.Value;
} |
Thanks a lot @pschader, You saved me from the frustration. Thanks again |
Fixed in the latest version! |
Hello, |
Face similar problem. Solved in last version. |
We recently added several recipes for implementing authentication with Keycloak in OHIF. You can find them here: |
I'm using lastest ohif viewer with docker (ohif/viewer:lastest), and I have configured to read my local images (dcm4chee). But when I try to open more of my studies I get this message:
Something went wrong in ViewerMain
ViewerMain: windowWidth.toFixed is not a function
And no images is shown.
The text was updated successfully, but these errors were encountered: