fix(MetadataProvider): Update metadata provider to resolve issues after dicomweb update/new return value #2363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate (string vs number)
igoroctaviano
force-pushed
the
fix/window-level-issues
branch
from
1efe49b
to
b8839b7
Compare
igoroctaviano
force-pushed
the
fix/window-level-issues
branch
from
b8839b7
to
c6bc19c
Compare
igoroctaviano
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2363 +/- ##
==========================================
- Coverage 13.52% 13.50% -0.02%
==========================================
Files 286 287 +1
Lines 7467 7485 +18
Branches 1408 1414 +6
==========================================
+ Hits 1010 1011 +1
- Misses 5243 5254 +11
- Partials 1214 1220 +6
Continue to review full report at Codecov.
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MetadataProvider should parse string values from the dataset to valid numbers to avoid parsing issues inside libraries that consume the provider like cornerstone.