-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MetadataProvider): Update metadata provider to resolve issues after dicomweb update/new return value #2363
Conversation
…ate (string vs number)
1efe49b
to
b8839b7
Compare
b8839b7
to
c6bc19c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## master #2363 +/- ##
==========================================
- Coverage 13.52% 13.50% -0.02%
==========================================
Files 286 287 +1
Lines 7467 7485 +18
Branches 1408 1414 +6
==========================================
+ Hits 1010 1011 +1
- Misses 5243 5254 +11
- Partials 1214 1220 +6
Continue to review full report at Codecov.
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
The MetadataProvider should parse string values from the dataset to valid numbers to avoid parsing issues inside libraries that consume the provider like cornerstone.