Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(memory leak): array buffer was sticking around in volume viewports #3611

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Aug 21, 2023

Context

purge cache was not freeing up memory since the deactivate texture calls had an exception which caused the scalardata to hang around.

Also previously we were terminating the web workers when going back to the worklist since that prob helped with the memory leak but has performance issues for invoking them again, that step is now removed, so you should expect perf gains going back and forth between studies and worklist

CC: @chafey (re web worker)

Changes & Results

re-order the destroy calls

Testing

after
CleanShot 2023-08-21 at 18 41 38

Before
CleanShot 2023-08-21 at 18 44 00

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 6e5a6b4
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/64e3ef7ab0ae7a0007e4e8fe
😎 Deploy Preview https://deploy-preview-3611--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 6e5a6b4
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/64e3ef7ab1ece70008bac2f1
😎 Deploy Preview https://deploy-preview-3611--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #3611 (6e5a6b4) into master (b117a54) will not change coverage.
Report is 2 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3611   +/-   ##
=======================================
  Coverage   42.58%   42.58%           
=======================================
  Files          80       80           
  Lines        1463     1463           
  Branches      340      340           
=======================================
  Hits          623      623           
  Misses        675      675           
  Partials      165      165           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe0ee05...6e5a6b4. Read the comment docs.

@cypress
Copy link

cypress bot commented Aug 21, 2023

Passing run #3470 ↗︎

0 37 0 0 Flakiness 0

Details:

pull master
Project: Viewers Commit: 6e5a6b4be1
Status: Passed Duration: 03:42 💡
Started: Aug 21, 2023 11:19 PM Ended: Aug 21, 2023 11:23 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

"@cornerstonejs/adapters": "^1.10.3",
"@cornerstonejs/core": "^1.10.3",
"@cornerstonejs/tools": "^1.10.3",
"@cornerstonejs/adapters": "^1.11.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get the prefetch fixes in as well? That issue is also related to how the memory gets handled, and I'd like to see the two of them combined.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean? in this PR? (I have not reviewed/tested that again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants