Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segmentations Settings UI - Phase 1 #1391 #1392

Merged
merged 142 commits into from
Mar 13, 2020
Merged

Segmentations Settings UI - Phase 1 #1391 #1392

merged 142 commits into from
Mar 13, 2020

Conversation

igoroctaviano
Copy link
Contributor

@igoroctaviano igoroctaviano commented Jan 24, 2020 •
edited
Loading

PR Checklist

#1391

  • Brief description of changes
  • Links to any relevant issues
  • Required status checks are passing
  • User cases if changes impact the user's experience
  • @mention a maintainer to request a review

JamesAPetts and others added 30 commits November 5, 2019 10:06
@JamesAPetts
Filter segs and fetch correct metadata.
d805397
@JamesAPetts
Initiate seg loading logic on series load into viewport. Need to write.
3bd2965
@JamesAPetts
Automatic consumption of SEG functional.
22e3df9
@JamesAPetts
Pull in master.
eb3a4b5
@JamesAPetts
Fix issues after pulling in master.
8d75620
@JamesAPetts
Clean up old segmentation handlers.
f122420
@JamesAPetts
WIP
9055926
@JamesAPetts
WIP
5014afc
@JamesAPetts
Poppulate viewport with metadata.
377f43d
@JamesAPetts
Show hide/segmentation in react-vtkjs-viewport.
0dc221d
@JamesAPetts
feat: 🎸 View segmentations in vtkjs viewport
66567ca
@JamesAPetts
Filter segs and fetch correct metadata.
75fe1f5
@JamesAPetts
Initiate seg loading logic on series load into viewport. Need to write.
934530d
@JamesAPetts
Automatic consumption of SEG functional.
8811c67
@JamesAPetts
Pull in master.
b963985
@JamesAPetts
Fix issues after pulling in master.
31efd9e
@JamesAPetts
Clean up old segmentation handlers.
a72add2
@JamesAPetts
WIP
45889e6
@JamesAPetts
WIP
868705d
@JamesAPetts
Poppulate viewport with metadata.
188ed27
@JamesAPetts
Show hide/segmentation in react-vtkjs-viewport.
c6100e0
@JamesAPetts
feat: 🎸 View segmentations in vtkjs viewport
893fca1
@JamesAPetts
Rebase on master.
8d9fa9a
@JamesAPetts
Pull in master.
7a929a2
@dannyrb
format format format
1a83df2
@dannyrb
add basic extension parts
1b3ad79
@dannyrb
Merge branch 'master' of github.com:OHIF/Viewers into vtkjsViewSegmen…
725c4f3 
…tations

# Conflicts:
#	platform/viewer/cypress/support/commands.js
#	platform/viewer/package.json
@dannyrb
Updated yarn lock
e90f598
@dannyrb
Fetch derived/referenced displaysets in sidepanel
f5a0a07
@JamesAPetts
Add buttons, expose seriesDescription, write notes for Danny.
0271e53
@fedorov fedorov added the IDC:priority Items that the Imaging Data Commons wants to help sponsor label Feb 24, 2020
@fedorov
Copy link
Member

fedorov commented Feb 27, 2020

I am getting this error:

image

@dannyrb
Copy link
Member

dannyrb commented Feb 27, 2020 •
edited
Loading

@fedorov, is there a specific route, study, or steps that cause that error for you? What browser are you testing on? I'm unable to reproduce on the latest netlify deploy preview.

@fedorov
Copy link
Member

fedorov commented Feb 27, 2020

We tried this at a call today, and @swederik, @JamesAPetts and @pieper were able to reproduce this. We were just selecting a study with SEG.

I tried again, and was able to reproduce it on the first try with this study: https://deploy-preview-1392--ohif.netlify.com/pwa/viewer/1.3.6.1.4.1.14519.5.2.1.3671.7001.133687106572018334063091507027

@pieper
Copy link
Member

pieper commented Feb 27, 2020 via email •
edited
Loading

dannyrb
dannyrb approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@dannyrb dannyrb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bulk of these changes are in extensions/*, so this feels fairly safe to merge. Notably, this removes the seg to cornerstone bridge that used to live in the cornerstone extension. You will need this extension to visualize, but I think that's just fine. We'll have "modes" near future to help us decouple everything bundled in these extensions.

The other core changes that jumped out to me were:

  • studies array passed to <Viewport />
  • studies and isOpen passed to <VisiblePanelRight />
  • Some core logic added for sorting, finding, caching derived datasets

Note: this PR will likely mess with the consistent DICOM Tag naming @JamesAPetts has worked to achieve. We need a linter to catch these.
Note: We should address the outstanding issue above. I'm curious to see if @JamesAPetts metadata changes have any impact.

@mirnasilva mirnasilva mentioned this pull request Mar 10, 2020
Merged
5 tasks
@dannyrb dannyrb merged commit e8842cf into master Mar 13, 2020
@fedorov fedorov mentioned this pull request Mar 16, 2020
Closed
@dannyrb dannyrb deleted the igor/1370-cog-settings branch June 24, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swederik swederik swederik left review comments

@dannyrb dannyrb dannyrb approved these changes

@JamesAPetts JamesAPetts Awaiting requested review from JamesAPetts

Assignees

@igoroctaviano igoroctaviano

Labels
IDC:priority Items that the Imaging Data Commons wants to help sponsor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@igoroctaviano @JamesAPetts @dannyrb @fedorov @pieper @swederik