Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(volumeLoad): should not have missing slices when loading #3287
fix(volumeLoad): should not have missing slices when loading #3287
Changes from all commits
5db3598
6845a49
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about cancelled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be able to resume the cancel, so I don't think so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, you need to remove the cancelled flag in the load then - that can wait for now, but you might want to test it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prefetch number is heavily dependent on protocol - running http/2 or /3 allows for high prefetch numbers, but a prefetch of 25 is too high for /1.1 or /1.0. The issue is that it starts blocking the fetch queue. I think I would add a comment here explaining a bit of that - I would also try as high as 100 and see if it makes a difference. If you consider a latency of 200 ms, for a fetch size of 200k, then the transfer time probably on the 20 ms time frame, and you want to completely consume all the latency time with transfer time, so that means in a perfect overlap situation, you need 20/200 = 10 prefetch, which in a practical world with random transfer times, you want 2-3 times that amount, so 25 is a good practical amount.